Gentoo Archives: gentoo-portage-dev

From: Duncan <1i5t5.duncan@×××.net>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] Re: [PATCHES] Remove --autounmask, rename --autounmask-write to --autounmask
Date: Thu, 21 Nov 2013 11:20:33
Message-Id: pan$36887$d4f00cae$2cc7e477$5c929a36@cox.net
In Reply to: [gentoo-portage-dev] [PATCHES] Remove --autounmask, rename --autounmask-write to --autounmask by Alexander Berntsen
1 Alexander Berntsen posted on Thu, 21 Nov 2013 10:21:02 +0100 as excerpted:
2
3 > After talking to zmedico privately, and raising the issue and discussing
4 > it with people in bug #481578[0], I implemented the behaviour described
5 > in a comment[1] on said bug.
6 >
7 > I sent this to zmedico almost two months ago, but it doesn't look like
8 > he's coming back any time soon, so I'm sending it here and ask someone
9 > to review and commit it (a role zmedico has typically played for me, as
10 > well as being my "mentor" and guide and so on and so forth for Portage
11 > hacking).
12 >
13 > [0] <https://bugs.gentoo.org/show_bug.cgi?id=481578>
14 > [1] <https://bugs.gentoo.org/show_bug.cgi?id=481578#c10>>
15
16 I'm with zmedico in comment #11, and *STRONGLY* oppose this change as
17 you're proposing. Current autounmask is **NOT** useless.
18
19 FWIW, I have a very specific portage layout and there's no way "dumb
20 automation" could put what I'd consider the appropriate write in what I'd
21 consider the appropriate file, nor do I want it to try! (And even if it
22 could do it perfectly, I want to /know/ what my config is, and the best
23 way for me to /know/ my config is if the only way it changes is if I
24 change it myself!)
25
26 OTOH, current default autounmask (without write) behavior, having portage
27 tell me what (it thinks) I need to unmask and/or what package.use flags
28 it thinks I need is fine, and often quite helpful indeed, as long as it's
29 not actually trying to actually WRITE it anywhere!
30
31 If I read the above correctly, what you're proposing would kill that
32 behavior entirely if --ask is used, defaulting to writing (fine if it can
33 be turned off), with no way (at least no way with --ask instead of
34 --pretend) to tell portage to make the suggestion it with --autounmask
35 (which is the default now), with absolutely no chance it's going to
36 attempt to actually rewrite my config on its own, period.
37
38 OTOH, Zac's suggestion, to simply enable autounmask-write by default but
39 allow the user to set --autounmask-write=n if they want, would be just
40 fine, since I could put that in default options and be done with it.
41
42 Tho even that's a sufficiently drastic change from current behavior that
43 I'd expect a good changelog entry mentioning it, and preferably a news
44 item, as it has the potential to screw up people's configs if they aren't
45 paying attention when the default changes.
46
47 --
48 Duncan - List replies preferred. No HTML msgs.
49 "Every nonfree program has a lord, a master --
50 and if you use the program, he is your master." Richard Stallman

Replies