Gentoo Archives: gentoo-portage-dev

From: Brian Dolbec <dolsen@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] repoman: make unused local USE flags an error
Date: Wed, 04 Jan 2017 22:29:04
Message-Id: 20170104142901.2d87af1d.dolsen@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] repoman: make unused local USE flags an error by Mike Gilbert
1 On Wed, 4 Jan 2017 13:14:38 -0500
2 Mike Gilbert <floppym@g.o> wrote:
3
4 > X-Gentoo-Bug: 602002
5 > X-Gentoo-Bug-URL: https://bugs.gentoo.org/602002
6 > ---
7 > repoman/pym/repoman/modules/scan/metadata/pkgmetadata.py | 2 +-
8 > 1 file changed, 1 insertion(+), 1 deletion(-)
9 >
10 > diff --git a/repoman/pym/repoman/modules/scan/metadata/pkgmetadata.py
11 > b/repoman/pym/repoman/modules/scan/metadata/pkgmetadata.py index
12 > 9e4d6cb93..92c74e6f8 100644 ---
13 > a/repoman/pym/repoman/modules/scan/metadata/pkgmetadata.py +++
14 > b/repoman/pym/repoman/modules/scan/metadata/pkgmetadata.py @@ -166,7
15 > +166,7 @@ class PkgMetadata(ScanBase, USEFlagChecks): if valid_state:
16 > for myflag in
17 > self.muselist.difference(self.usedUseFlags): self.qatracker.add_error(
18 > - "metadata.warning",
19 > + "metadata.bad",
20 > "%s/metadata.xml: unused
21 > local USE-description: '%s'" % (xpkg, myflag))
22 > return False
23
24
25 Thanks, looks good.
26 --
27 Brian Dolbec <dolsen>

Replies