Gentoo Archives: gentoo-portage-dev

From: "Ulrich Müller" <ulm@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Ulrich Müller" <ulm@g.o>
Subject: [gentoo-portage-dev] [PATCH] eend: Output QA notice when called without argument
Date: Fri, 03 Sep 2021 16:59:02
Message-Id: 20210903165844.29969-1-ulm@gentoo.org
1 PMS says about eend: "Takes one fixed argument, which is a numeric
2 return code, and an optional message in all subsequent arguments."
3
4 Bug: https://bugs.gentoo.org/703520
5 Signed-off-by: Ulrich Müller <ulm@g.o>
6 ---
7 bin/isolated-functions.sh | 1 +
8 1 file changed, 1 insertion(+)
9
10 diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
11 index b495ae6c7..5b1f372d2 100644
12 --- a/bin/isolated-functions.sh
13 +++ b/bin/isolated-functions.sh
14 @@ -364,6 +364,7 @@ __eend() {
15 }
16
17 eend() {
18 + [[ -n $1 ]] || eqawarn "QA Notice: eend called without return code"
19 local retval=${1:-0}
20 shift
21
22 --
23 2.33.0

Replies