Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] fetch(): fix support for digest size=None
Date: Sun, 05 Apr 2015 17:58:05
Message-Id: 552177A5.60308@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] fetch(): fix support for digest size=None by "Michał Górny"
1 On 04/05/2015 12:59 AM, Michał Górny wrote:
2 > It seems that the code initially supported fetching without size
3 > 'digest' but it got broken over time. Add proper conditionals to avoid
4 > ugly failures in this case.
5
6 If we're handling this case, then we should probably not assume that the
7 dict contains a "size" key. So, we could check that dict.get("size") is
8 not None.
9 --
10 Thanks,
11 Zac

Replies