Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH] sync: fix module_names enumeration
Date: Sat, 17 Jan 2015 22:41:52
Message-Id: 54BAE52B.7050507@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] sync: fix module_names enumeration by "Michał Górny"
1 On 01/17/2015 05:16 AM, Michał Górny wrote:
2 > Fix module_names enumeration to consider all modules. Before, the first
3 > module on the list was omitted ('cvs' in this case).
4 >
5 > Another thing is, the CVS module is completely, utterly and inevitably
6 > broken. And the whole syncing thing is a great pile of terribly
7 > mis-designed, unnecessarily complex code which can't work unless it is
8 > worked around like git module does...
9 > ---
10 > pym/portage/sync/controller.py | 2 +-
11 > 1 file changed, 1 insertion(+), 1 deletion(-)
12
13 LGTM, except this commit message is not a proper place to rant about
14 stuff...
15 --
16 Thanks,
17 Zac