Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: "Michał Górny" <mgorny@g.o>
Cc: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] Manifest._apply_max_mtime: account for removals and renames (bug 567920)
Date: Tue, 15 Dec 2015 16:50:23
Message-Id: 567044C2.2080409@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] Manifest._apply_max_mtime: account for removals and renames (bug 567920) by "Michał Górny"
1 On 12/15/2015 12:43 AM, Michał Górny wrote:
2 > On Tue, 15 Dec 2015 00:10:03 -0800
3 > Zac Medico <zmedico@g.o> wrote:
4 >
5 >> Include directory mtimes in the max mtime calculation, in order
6 >> to account for removals and renames.
7 >
8 > Mildly irrelevant but I think this reached the point when we want to
9 > make this optional, and off by default. In other words, we want
10 > 'repoman manifest' run explicitly to work the old way.
11 >
12
13 I suppose we could support a "stable-mtime = true" attribute that would
14 be set in layout.conf and/or repos.conf.
15
16 Theoretically, the difference in behavior is negligible except where
17 comparisons by tools like rsync are concerned. I have to admit that I
18 was a little bit nervous that something like bug 567920 might come up.
19 Now that directory mtimes are accounted for, I'm practically certain
20 that any relevant changes will cause the Manifest mtime to increase.
21 --
22 Thanks,
23 Zac

Replies