Gentoo Archives: gentoo-portage-dev

From: Sergei Trofimovich <slyfox@g.o>
To: gentoo-portage-dev@l.g.o
Cc: mgorny@g.o
Subject: Re: [gentoo-portage-dev] [PATCH 16/18] Disallow helpers in global scope in EAPI 6
Date: Fri, 16 Jan 2015 10:14:11
Message-Id: 20150116101401.1e573a6a@sf
In Reply to: [gentoo-portage-dev] [PATCH 16/18] Disallow helpers in global scope in EAPI 6 by "Michał Górny"
1 On Mon, 1 Dec 2014 22:28:34 +0100
2 Michał Górny <mgorny@g.o> wrote:
3
4 > Disallow calling most of the ebuild helpers in global scope since they
5 > are meaningless in that context. Most of them are also prohibited by PMS
6 > for all EAPIs, so EAPI 6 sounds like a good moment to finally enforce
7 > that restriction.
8 > ---
9 > bin/eapi.sh | 2 +-
10 > 1 file changed, 1 insertion(+), 1 deletion(-)
11 >
12 > diff --git a/bin/eapi.sh b/bin/eapi.sh
13 > index e0ade02..5ab92f4 100644
14 > --- a/bin/eapi.sh
15 > +++ b/bin/eapi.sh
16 > @@ -159,7 +159,7 @@ ___eapi_helpers_can_die() {
17 > }
18 >
19 > ___eapi_disallows_helpers_in_global_scope() {
20 > - [[ ${1-${EAPI}} =~ ^(4-python|5-progress)$ ]]
21 > + [[ ! ${1-${EAPI}} =~ ^(0|1|2|3|4|4-slot-abi|5|5-hdepend)$ ]]
22 > }
23 >
24 > ___eapi_unpack_is_case_sensitive() {
25
26 Looks like it cries on ebuilds with unset EAPI in main tree (attached).
27 Can be easily fixed in tree by adding EAPI=0, but better handle it
28 here: ${EAPI-0} (untested!)
29
30 It also changed binutils: it used to be slotted only in presence of USE flag.
31 Now it's always slotted even with USE=-multislot (at least eix thinks so).
32
33 --
34
35 Sergei

Attachments

File name MIME type
bad-log.txt text/plain
signature.asc application/pgp-signature

Replies