Re: [gentoo-portage-dev] [PATCH v3] movefile: support in-kernel file copying on Linux (bug 607868)

[Brian Dolbec]

On Fri,  3 Mar 2017 18:18:50 -0800
Zac Medico <zmedico@g.o> wrote:

> Perform in-kernel file copying when possible, and also support
> reflinks and sparse files. If the optimized implementation
> fails at runtime, gracefully fallback to a plain read/write
> loop.
>
> Compile-time and run-time fallbacks are implemented, so that
> any incompatiblities will be handled gracefully. For example,
> if the code is compiled on a system that supports the
> copy_file_range syscall, but at run-time an older kernel that
> does not support this syscall is detected, it will be handled
> gracefully. There are similar fallbacks for lack of lseek
> SEEK_DATA and sendfile support.
>
> X-Gentoo-Bug: 607868
> X-Gentoo-Bug-Url: https://bugs.gentoo.org/show_bug.cgi?id=607868
> ---
> [PATCH v3] Changes:
>  * Add function documentation comments
>  * Rename do_lseek function to do_lseek_data
>  * Fix do_lseek_data to handle sparse blocks at EOF, and
>    fix _reflink_linux_file_copy to call ftruncate
>  * Eliminate indirection in python copyfile function
>  * Cleaned up error variable handling
>  * Added lseek calls to ensure correct revovery from EINTR
>  * Added buf != NULL call before free(buf)
>
>  pym/portage/tests/util/file_copy/__init__.py      |   0
>  pym/portage/tests/util/file_copy/__test__.py      |   0
>  pym/portage/tests/util/file_copy/test_copyfile.py |  71 ++++
>  pym/portage/util/file_copy/__init__.py            |  36 ++
>  pym/portage/util/movefile.py                      |   4 +-
>  setup.py                                          |   9 +
>  src/portage_util_file_copy_reflink_linux.c        | 385
> ++++++++++++++++++++++ 7 files changed, 504 insertions(+), 1
> deletion(-) create mode 100644


I'd say go for it, merge.  There's been no additional feedback or review


-- 
Brian Dolbec <dolsen>