| 1 |
On 09/17/2014 02:28 PM, Michał Górny wrote: |
| 2 |
>> diff --git a/pym/portage/repository/config.py b/pym/portage/repository/config.py |
| 3 |
>> index 5e0d055..ef8054e 100644 |
| 4 |
>> --- a/pym/portage/repository/config.py |
| 5 |
>> +++ b/pym/portage/repository/config.py |
| 6 |
>> @@ -40,7 +40,7 @@ if sys.hexversion >= 0x3000000: |
| 7 |
>> _invalid_path_char_re = re.compile(r'[^a-zA-Z0-9._\-+:/]') |
| 8 |
>> |
| 9 |
>> _valid_profile_formats = frozenset( |
| 10 |
>> - ['pms', 'portage-1', 'portage-2']) |
| 11 |
>> + ['pms', 'portage-1', 'portage-2', 'profile-env']) |
| 12 |
> |
| 13 |
> I'm not sure if dedicated profile format is the best way to go. If I |
| 14 |
> understand your patch correctly, this means that 'profile-env' has only |
| 15 |
> features of PMS profile but not of 'portage-*' formats. This could mean |
| 16 |
> that some people would have to choose between features of one or |
| 17 |
> the other. Since both are compatible, i suggest 'portage-3' instead. |
| 18 |
|
| 19 |
The profile-formats field is designed to allow mixing of formats. So, |
| 20 |
it's legal to mix profile-env with any of the other formats. |
| 21 |
-- |
| 22 |
Thanks, |
| 23 |
Zac |
Archives