Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-portage-dev] [PATCH] sync: fix module_names enumeration
Date: Sat, 17 Jan 2015 13:16:51
Message-Id: 1421500603-15692-1-git-send-email-mgorny@gentoo.org
1 Fix module_names enumeration to consider all modules. Before, the first
2 module on the list was omitted ('cvs' in this case).
3
4 Another thing is, the CVS module is completely, utterly and inevitably
5 broken. And the whole syncing thing is a great pile of terribly
6 mis-designed, unnecessarily complex code which can't work unless it is
7 worked around like git module does...
8 ---
9 pym/portage/sync/controller.py | 2 +-
10 1 file changed, 1 insertion(+), 1 deletion(-)
11
12 diff --git a/pym/portage/sync/controller.py b/pym/portage/sync/controller.py
13 index 9001298..3d217db 100644
14 --- a/pym/portage/sync/controller.py
15 +++ b/pym/portage/sync/controller.py
16 @@ -119,7 +119,7 @@ class SyncManager(object):
17 self.callback = callback or self._sync_callback
18 self.repo = repo
19 self.exitcode = 1
20 - if repo.sync_type in self.module_names[1:]:
21 + if repo.sync_type in self.module_names:
22 tasks = [self.module_controller.get_class(repo.sync_type)]
23 else:
24 msg = "\n%s: Sync module '%s' is not an installed/known type'\n" \
25 --
26 2.2.1

Replies