Archives
Archives
| From: | Mike Frysinger <vapier@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o | ||
| Cc: | Arfrever Frehtes Taifersar Arahesis <arfrever.fta@×××××.com>, davidjames@××××××××.org | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH] prepstrip: rewrite in python | ||
| Date: | Thu, 17 Oct 2013 03:05:22 | ||
| Message-Id: | 201310162305.22521.vapier@gentoo.org | ||
| In Reply to: | Re: [gentoo-portage-dev] [PATCH] prepstrip: rewrite in python by Arfrever Frehtes Taifersar Arahesis |
||
| 1 | On Wednesday 16 October 2013 19:26:04 Arfrever Frehtes Taifersar Arahesis |
| 2 | wrote: |
| 3 | > 2013-10-16 23:34 Mike Frysinger napisał(a): |
| 4 | > > + raise subprocess.CalledProcessError('command failed |
| 5 | (ret=%i): %s' % ( |
| 6 | > > + proc.returncode, ' '.join(map(repr, cmd)))) |
| 7 | > |
| 8 | > A generator expression would look better than map(). |
| 9 | |
| 10 | i don't see how |
| 11 | |
| 12 | i fixed the rest and ran it through a linter |
| 13 | -mike |
| File name | MIME type |
|---|---|
| signature.asc | application/pgp-signature |