Re: [gentoo-portage-dev] [PATCH] [sync] Increase the default git sync-depth to 10

[Zac Medico]

On 10/30/2016 02:34 PM, Michał Górny wrote:
> Increate the default git sync-depth from 1 to 10, to ensure that

s/Increate/Increase/

> gentoo-mirror git clones retain at least a single original signed
> commit.
> ---
>  man/portage.5                            | 10 ++++++++--
>  pym/portage/sync/modules/git/__init__.py |  2 +-
>  2 files changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/man/portage.5 b/man/portage.5
> index 963f49d..c1e4d97 100644
> --- a/man/portage.5
> +++ b/man/portage.5
> @@ -965,8 +965,14 @@ Specifies priority of given repository.
>  Specifies CVS repository.
>  .TP
>  .B sync\-depth
> -Specifies clone depth to use for DVCS repositories. Defaults to 1 (only
> -the newest commit). If set to 0, the depth is unlimited.
> +Specifies clone depth to use for DVCS repositories. Defaults to 10
> +(commits deep). If set to 0, the depth is unlimited.
> +.br
> +The default depth of 10 was chosen as a compromise between space
> +and bandwidth savings, and maintaining a history of recent commits.
> +It is especially important for gentoo-mirror repositories where the most
> +recent commits are automated and unsigned, and it is necessary to
> +rewind the history to the newest signed commit for OpenPGP verification.

Shouldn't people feel uneasy about the last commit being unverifiable? I
would think that that last commit should be signed with an
infrastructure key.

>  .TP
>  .B sync\-git\-clone\-extra\-opts
>  Extra options to give to git when cloning repository (git clone).
> diff --git a/pym/portage/sync/modules/git/__init__.py b/pym/portage/sync/modules/git/__init__.py
> index d5eb5c6..54070fc 100644
> --- a/pym/portage/sync/modules/git/__init__.py
> +++ b/pym/portage/sync/modules/git/__init__.py
> @@ -18,7 +18,7 @@ class CheckGitConfig(CheckSyncConfig):
>  	def check_depth(self):
>  		d = self.repo.sync_depth
>  		# default
> -		self.repo.sync_depth = 1
> +		self.repo.sync_depth = 10
>
>  		if d is not None:
>  			try:
>


-- 
Thanks,
Zac