Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [GLEP59v2 5/5] GLEP59: Change live Manifest2 hashes to SHA256, SHA512, WHIRLPOOL
Date: Mon, 03 Oct 2011 09:49:19
Message-Id: 4E898507.90302@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [GLEP59v2 5/5] GLEP59: Change live Manifest2 hashes to SHA256, SHA512, WHIRLPOOL by Zac Medico
1 On 10/02/2011 05:21 PM, Zac Medico wrote:
2 > On 10/02/2011 04:22 PM, Brian Harring wrote:
3 >> On Sun, Oct 02, 2011 at 02:10:09PM -0700, Zac Medico wrote:
4 > I've implemented it with booleans in this commit:
5 >
6 > http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=c8cd3a985cc529299411d7343a11004b7d1330ef
7 >
8 >> Should use a space delimited list instead named hashes instead; those
9 >> being the hashes that should be generated, and that can be /used/.
10 >> Not in the list, not an acceptable hash (even if a manifest2 carries
11 >> that data).
12 >
13 > Why? Boolean flags are simpler and they work.
14
15 After some thought, I like the space delimited approach better. Here's
16 the patch, which retains the ability to remove the manifest hash
17 settings from layout.conf after they become redundant:
18
19 http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=d9d0606fe01618cc81fb0b862ada91149dad3746
20 --
21 Thanks,
22 Zac

Replies