Re: [gentoo-portage-dev] [PATCH] test_required_use: Add tests for ?? operator

[Zac Medico]

On 02/26/2018 04:40 AM, Michał Górny wrote:
> ---
>  pym/portage/tests/resolver/test_required_use.py | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
>
> diff --git a/pym/portage/tests/resolver/test_required_use.py b/pym/portage/tests/resolver/test_required_use.py
> index c8810faef..d40222204 100644
> --- a/pym/portage/tests/resolver/test_required_use.py
> +++ b/pym/portage/tests/resolver/test_required_use.py
> @@ -44,6 +44,12 @@ class RequiredUSETestCase(TestCase):
>  			"dev-libs/D-3" : {"EAPI": "4", "IUSE": "+w +x y z",     "REQUIRED_USE": "w? ( x || ( y z ) )"},
>  			"dev-libs/D-4" : {"EAPI": "4", "IUSE": "+w x +y +z",    "REQUIRED_USE": "w? ( x || ( y z ) )"},
>  			"dev-libs/D-5" : {"EAPI": "4", "IUSE": "w x y z",       "REQUIRED_USE": "w? ( x || ( y z ) )"},
> +
> +			"dev-libs/E-1" : {"EAPI": "5", "IUSE": "foo bar",   "REQUIRED_USE": "?? ( foo bar )"},
> +			"dev-libs/E-2" : {"EAPI": "5", "IUSE": "foo +bar",  "REQUIRED_USE": "?? ( foo bar )"},
> +			"dev-libs/E-3" : {"EAPI": "5", "IUSE": "+foo bar",  "REQUIRED_USE": "?? ( foo bar )"},
> +			"dev-libs/E-4" : {"EAPI": "5", "IUSE": "+foo +bar", "REQUIRED_USE": "?? ( foo bar )"},
> +			"dev-libs/E-5" : {"EAPI": "5", "IUSE": "+foo +bar", "REQUIRED_USE": "?? ( )"},
>  			}
>
>  		test_cases = (
> @@ -79,6 +85,12 @@ class RequiredUSETestCase(TestCase):
>  			ResolverPlaygroundTestCase(["=dev-libs/D-3"],  success = False),
>  			ResolverPlaygroundTestCase(["=dev-libs/D-4"],  success = False),
>  			ResolverPlaygroundTestCase(["=dev-libs/D-5"],  success = True, mergelist=["dev-libs/D-5"]),
> +
> +			ResolverPlaygroundTestCase(["=dev-libs/E-1"], success = True, mergelist=["dev-libs/E-1"]),
> +			ResolverPlaygroundTestCase(["=dev-libs/E-2"], success = True, mergelist=["dev-libs/E-2"]),
> +			ResolverPlaygroundTestCase(["=dev-libs/E-3"], success = True, mergelist=["dev-libs/E-3"]),
> +			ResolverPlaygroundTestCase(["=dev-libs/E-4"], success = False),
> +			ResolverPlaygroundTestCase(["=dev-libs/E-5"], success = True, mergelist=["dev-libs/E-5"]),
>  			)
>
>  		playground = ResolverPlayground(ebuilds=ebuilds)
>

Looks good, please merge.
-- 
Thanks,
Zac