Gentoo Archives: gentoo-portage-dev

From: Duncan <1i5t5.duncan@×××.net>
To: gentoo-portage-dev@l.g.o
Subject: [gentoo-portage-dev] Re: [PATCH] repoman: declare '-x', '--xmlparse' command line options obsolete
Date: Fri, 20 May 2016 04:14:27
Message-Id: pan$c3533$a4c1a334$5da8cba6$bfcb3c4@cox.net
In Reply to: [gentoo-portage-dev] [PATCH] repoman: declare '-x', '--xmlparse' command line options obsolete by "Göktürk Yüksek"
1 Göktürk Yüksek posted on Thu, 19 May 2016 18:45:29 -0400 as excerpted:
2
3 > Repoman pulls in lxml unconditionally now and performs metadata checks
4 > by default. This behavior makes these command line options obsolete
5 > since forcing the default makes little sense. Declare them obsolete
6 > instead of removing them for backwards compatibility.
7
8 I like the general idea, but not the implementation. =:^(
9
10 Example...
11
12 > -\fB-x\fR, \fB--xmlparse\fR
13 > -Forces the metadata.xml parse check to be carried out
14 > +\fB-x\fR, \fB--xmlparse\fR (OBSOLETE)
15
16
17 Often I'll find some online resource that recommends some command, but I
18 (arguably wisely!) prefer to check the manpage to see what a command and
19 its recommended options actually do, as opposed to just running it. That
20 way, in addition to protecting myself from rm -rf .* type advice as
21 sometimes found online, I learn as I go and can then apply the new
22 knowledge to similar situations, instead of being lost when an arbitrary
23 command copied without understanding doesn't work.
24
25 Or maybe I'm simply trying to fix an old, poorly documented script that
26 just broke, and am trying to figure out what some command therein
27 actually does.
28
29 The problem is outdated options with no hint as to what they actually did
30 before they were obsoleted and how to proceed with updating them for use
31 with newer versions. Were they obsoleted by more flexible options so the
32 old version isn't needed but I need to figure out what new option to use
33 and its format? Is that behavior now the default? Was that
34 functionality removed and thus is no longer available?
35
36 So please, don't just declare it obsolete without saying what it actually
37 did and if it applies, what the current equivalent might be. Doing so is
38 if anything even more frustrating to someone trying to figure out what
39 the option actually did, than removing it from the documentation entirely!
40
41 So, perhaps (I'm not going to attempt formatting)...
42
43 --xmlparse (Obsolete, formerly forced a metadata.xml parse check but
44 that's now default behavior.)
45
46 That way, anyone seeing the option somewhere in old code will still be
47 able to lookup what it did, and know that they can simply mentally ignore
48 that option when mentally tracing the old code in their head and delete
49 it in their updated version, because it's now the default.
50
51 --
52 Duncan - List replies preferred. No HTML msgs.
53 "Every nonfree program has a lord, a master --
54 and if you use the program, he is your master." Richard Stallman