Re: [gentoo-portage-dev] [PATCH 3/3] Have repoman deprecate G2CONF for the GNOME team. (bug #482084).

[Tom Wijsman]

On Wed, 15 Jan 2014 20:23:26 -0500
"Jesus Rivero (Neurogeek)" <neurogeek@g.o> wrote:

> On Jan 15, 2014 7:08 PM, "Tom Wijsman" <tomwij@g.o> wrote:
>
> > PortageInternalVariableAssignment(LineCheck): e += ' on line: %d'
> >                 return e
> >
> > +class DeprecateG2CONF(LineCheck):
> > +       repoman_check_name = 'G2CONF.deprecated'
> > +       re = re.compile(r'.*G2CONF.*')
> > +
> > +       def check(self, num, line):
> > +               """Run the check on line and return error if there
> > is
> one"""
> > +               m = self.re.match(line)
> > +               if m is not None:
> > +                       return ("G2CONF on line %d is deprecated,
> > see Gentoo bug #482084.")
>
> Are you missing the line number interpolation here? or %d is supposed
> to be returned?

That is filled in by the function which calls check(...), you can see
the same happen with the "e += ' on line: %d'" of the other check that
made it into the context of this patch; when testing this, it worked
properly in the repoman output.

-- 
With kind regards,

Tom Wijsman (TomWij)
Gentoo Developer

E-mail address  : TomWij@g.o
GPG Public Key  : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2  ABF0 95B2 1FCD 6D34 E57D