| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA256 |
| 3 |
|
| 4 |
On 20/02/14 01:08, Pavel Kazakov wrote: |
| 5 |
>> """Scan for failed merges fix them.""" |
| 6 |
> All the other modules put the second """ on a newline, so I wanted |
| 7 |
> to be consistent. Should I still make the change? |
| 8 |
What the other modules are doing is not necessarily an indication of |
| 9 |
what we should do. More often than not, they are the opposite of what |
| 10 |
we should do, and following them because "hey it might be terrible, |
| 11 |
but at least it's consistently terrible" isn't fruitful. So I agree |
| 12 |
with Alec. |
| 13 |
|
| 14 |
If you want consistency, feel free to fix the other docstrings. ;-) |
| 15 |
|
| 16 |
>> 'module1' ? |
| 17 |
> All the other modules did it this way, so I wanted consistency. |
| 18 |
Same. |
| 19 |
|
| 20 |
>> What is this little guy? Can we just do this in a library |
| 21 |
>> someplace? |
| 22 |
> Checks if python version is greater than or equal to 3, but I |
| 23 |
> probably don't even need it since I'm not using longs. |
| 24 |
Arfrever has apparently inserted this kind of stuff a bunch of places. |
| 25 |
We should figure out a more systematic approach... Anyway, if you |
| 26 |
don't even need it, get rid of it. |
| 27 |
- -- |
| 28 |
Alexander |
| 29 |
bernalex@g.o |
| 30 |
https://secure.plaimi.net/~alexander |
| 31 |
-----BEGIN PGP SIGNATURE----- |
| 32 |
Version: GnuPG v2.0.22 (GNU/Linux) |
| 33 |
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
| 34 |
|
| 35 |
iF4EAREIAAYFAlMF39gACgkQRtClrXBQc7VSUgD/UpF2Yrb/R72yAv8e9jIV9gj4 |
| 36 |
GYS+XKL8vTqb3EZr6+AA+wV/D6VQHOA7fHpW/ijaxfY+LYfMpcDxXEgZZXvqoB7C |
| 37 |
=xrzm |
| 38 |
-----END PGP SIGNATURE----- |
Archives