1 |
On 09/22/2014 08:56 AM, Michał Górny wrote: |
2 |
> Fixes: https://bugs.gentoo.org/show_bug.cgi?id=523182 |
3 |
> --- |
4 |
> bin/phase-functions.sh | 4 ++++ |
5 |
> bin/phase-helpers.sh | 4 ++++ |
6 |
> 2 files changed, 8 insertions(+) |
7 |
|
8 |
Your changes appear to correctly fix the specific issue reported in bug |
9 |
523182. However, I have a question about some of the other code in |
10 |
commit 772ed29fd9e7cf722aed943adbe33a27f250e1ff: |
11 |
|
12 |
case "$eapi" in |
13 |
0|1) # EAPIs not supporting 'default' |
14 |
|
15 |
for x in pkg_nofetch src_unpack src_test ; do |
16 |
declare -F $x >/dev/null || \ |
17 |
eval "$x() { __eapi0_$x; }" |
18 |
done |
19 |
|
20 |
It appears as though pkg_nofetch is only defined for EAPIs 0 and 1. |
21 |
Doesn't it also need to be defined for all of the other EAPIs? I can see |
22 |
that src_unpack and src_test are defined later for the other EAPIs, but |
23 |
pkg_nofetch is conspicuously absent. |
24 |
-- |
25 |
Thanks, |
26 |
Zac |