Re: [gentoo-portage-dev] [PATCH 2/3] Send output of ```emerge --version``` as User-Agent HTTP-header

[Zac Medico]

On 08/14/2013 01:10 PM, Mark Kubacki wrote:
> @@ -892,8 +893,13 @@ class binarytree(object):
>  				# Don't use urlopen for https, since it doesn't support
>  				# certificate/hostname verification (bug #469888).
>  				if parsed_url.scheme not in ('https',):
> +					trees = load_emerge_config().trees
> +					user_agent = "Gentoo "+getportageversion(self.settings["PORTDIR"], None,
> +							self.settings.profile_path, self.settings["CHOST"],
> +							trees[self.settings['EROOT']]["vartree"].dbapi)

Generally, your patches look reasonable. However, it's a waste to call
load_emerge_config() here, since the caller has certainly loaded the
config already. I guess we could have the caller pass the result of
getportageversion() as an argument to the binarytree.populate() method.
-- 
Thanks,
Zac