| 1 |
Hi, thank you for reviewing |
| 2 |
|
| 3 |
On Wed, Jun 17, 2015 at 01:32:17PM -0700, Brian Dolbec wrote: |
| 4 |
> Be aware that I have not read over the diff very much yet. |
| 5 |
> |
| 6 |
> On Wed, 17 Jun 2015 20:40:30 +0200 |
| 7 |
> Étienne Buira <etienne.buira@×××××.com> wrote: |
| 8 |
> |
| 9 |
> > diff --git a/pym/portage/package/ebuild/config.py |
| 10 |
> > b/pym/portage/package/ebuild/config.py index 3a4007b..08db363 100644 |
| 11 |
> > --- a/pym/portage/package/ebuild/config.py |
| 12 |
> > +++ b/pym/portage/package/ebuild/config.py |
| 13 |
> > @@ -515,6 +515,8 @@ class config(object): |
| 14 |
> > v = confs.get("SYNC") |
| 15 |
> > if v is not None: |
| 16 |
> > portdir_sync = v |
| 17 |
> > + if 'PORTAGE_RSYNC_EXTRA_OPTS' in |
| 18 |
> > confs: |
| 19 |
> > + |
| 20 |
> > self['PORTAGE_RSYNC_EXTRA_OPTS'] = confs['PORTAGE_RSYNC_EXTRA_OPTS'] |
| 21 |
> > self["PORTDIR"] = portdir |
| 22 |
> > self["PORTDIR_OVERLAY"] = portdir_overlay |
| 23 |
> |
| 24 |
> Not sure why ebuild/config.py needs changes... will look at it more |
| 25 |
|
| 26 |
For the same reason the same thing is done about ['SYNC']: forwarding |
| 27 |
its value to RepoConfigLoader.__init__ settings argument. |
| 28 |
|
| 29 |
> > diff --git a/pym/portage/repository/config.py |
| 30 |
> > b/pym/portage/repository/config.py index b7c969d..196b87a 100644 |
| 31 |
> > --- a/pym/portage/repository/config.py |
| 32 |
> > +++ b/pym/portage/repository/config.py |
| 33 |
> |
| 34 |
> |
| 35 |
> This approach is not wanted, it means hard coding any sync module |
| 36 |
> options in the main loader that might be sync-type specific. |
| 37 |
> |
| 38 |
> We want to make it generic so any arbitrary sync-type options (more |
| 39 |
> than the base required options) can be added for any module without the |
| 40 |
> need to change this. Those options are not used anywhere else other |
| 41 |
> than the sync module. |
| 42 |
|
| 43 |
Ok, patchset follows. |
| 44 |
|
| 45 |
> One method might be to replace the copying of the configparser options |
| 46 |
> into python variables. Instead change it to look for the option in the |
| 47 |
> configparser instance. And only maintain some base options or |
| 48 |
> functions which pull from the config instance. |
| 49 |
|
| 50 |
Not sure i understood what you meant, nor how that would look like, |
| 51 |
please explain if patchset is not oked. |
| 52 |
|
| 53 |
Regards. |
Archives