| 1 |
On Fri, 6 Nov 2015 09:20:45 +0100 |
| 2 |
Alexander Berntsen <bernalex@g.o> wrote: |
| 3 |
|
| 4 |
> -----BEGIN PGP SIGNED MESSAGE----- |
| 5 |
> Hash: SHA512 |
| 6 |
> |
| 7 |
> On 06/11/15 09:05, Michał Górny wrote: |
| 8 |
> >>> I know nothing about the egencache stuff. Maybe Michał can |
| 9 |
> >>> comment? |
| 10 |
> > Michał finds this black magic. Trusts zmedico. |
| 11 |
> I think it looks like it's probably supposed to be reasonable, |
| 12 |
> perhaps. |
| 13 |
> |
| 14 |
> Maybe Brian can look at it. At least that way we'll have a lot of |
| 15 |
> people that attempted understanding what's going on. |
| 16 |
> |
| 17 |
> Maybe we need a "Trusted-by:" line. |
| 18 |
> - -- |
| 19 |
> Alexander |
| 20 |
> bernalex@g.o |
| 21 |
|
| 22 |
|
| 23 |
Well, the changes look pretty straight forward. I thought we had |
| 24 |
handled not updating the caches/ running postsync hooks if it didn't |
| 25 |
sync, but Zac obviously found one that slipped through. |
| 26 |
|
| 27 |
Seeing the patch only doesn't give an entirely clear picture of the |
| 28 |
changes. For that you would have to read the code and the changes in |
| 29 |
the code to figure them all out. But I too trust Zac, and I don't |
| 30 |
feel this is complex and critical enough to warrant the time needed to |
| 31 |
study all the changes. I know he's tested the code ;) |
| 32 |
|
| 33 |
But I thought I saw a typo when you used BOOLEAN1 |= BOOLEAN2. I'd |
| 34 |
never seen the | used like that. It is nearly impossible to find any |
| 35 |
docs/examples of it. But I did find it as a bitwise or on integers |
| 36 |
which boolean is a special form of. Interesting that it is equivalent |
| 37 |
to a = max(a,b) |
| 38 |
|
| 39 |
|
| 40 |
|
| 41 |
-- |
| 42 |
Brian Dolbec <dolsen> |
Archives