| 1 |
On Wednesday 23 May 2012 15:21:51 Mike Frysinger wrote: |
| 2 |
> + self._inherit_re = re.compile(r'^\s*inherit\s(.*\s)?%s(\s|$)' % |
| 3 |
|
| 4 |
in scanning the whole tree, this seems to cause some issues (not new) with |
| 5 |
extended constructs and not detecting this ebuilds inherits an eclass |
| 6 |
directly. some examples: |
| 7 |
|
| 8 |
(1) |
| 9 |
foo="autotools" |
| 10 |
... |
| 11 |
inherit ${foo} |
| 12 |
this seems pointless imo since we've already ruled that multiple `inherit` |
| 13 |
calls are OK |
| 14 |
|
| 15 |
(2) |
| 16 |
inherit ... \ |
| 17 |
autotools |
| 18 |
this is annoying. maybe we should adapt the core line code to unroll these |
| 19 |
before passing to the individual checks ? |
| 20 |
|
| 21 |
(3) |
| 22 |
[[ ${PV} == "9999" ]] && inherit autotools |
| 23 |
this one would require tweaking the regex like so: |
| 24 |
(^[[:space:]]*|[[:space:]])inherit |
| 25 |
|
| 26 |
any opinions ? |
| 27 |
-mike |
Archives