Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] doins: don't clobber _E_INSDESTTREE_
Date: Thu, 08 Mar 2018 19:25:44
Message-Id: 1520537137.1046.1.camel@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH] doins: don't clobber _E_INSDESTTREE_ by Mike Gilbert
1 W dniu czw, 08.03.2018 o godzinie 14∶17 -0500, użytkownik Mike Gilbert
2 napisał:
3 > This might be set by another helper function (doconfd, doenvd, doheader).
4 >
5 > Bug: https://bugs.gentoo.org/649946
6 > Fixes: a5d0111d0bdaa7ee9e5c68e22b4a97ce415e119b
7 > ---
8 > bin/ebuild-helpers/doins | 2 +-
9 > 1 file changed, 1 insertion(+), 1 deletion(-)
10 >
11 > diff --git a/bin/ebuild-helpers/doins b/bin/ebuild-helpers/doins
12 > index 327d409a4..219bbe5d7 100755
13 > --- a/bin/ebuild-helpers/doins
14 > +++ b/bin/ebuild-helpers/doins
15 > @@ -20,7 +20,7 @@ else
16 > if ! ___eapi_has_DESTTREE_INSDESTTREE; then
17 > [[ -n ${INSDESTTREE} ]] &&
18 > die "${0##*/}: \${INSDESTTREE} has been banned for EAPI '$EAPI'; use 'into' instead"
19 > - else
20 > + elif [[ -z ${_E_INSDESTTREE_+set} ]]; then
21 > # backwards compatibility
22 > _E_INSDESTTREE_=${INSDESTTREE}
23 > fi
24
25 This breaks using INSDESTTREE completely since _E_INSDESTTREE_ is always
26 set (defaulted).
27
28 --
29 Best regards,
30 Michał Górny