[gentoo-portage-dev] egencache and dotfiles

[Chris White]

When egencache attempts to parse cache files in a directory containing dotfiles, .gitignore for example, a failure occurs:

Unable to parse cp for '.gitignore'

The related code appears to be here (bin/egencache):

----------------------------------------------------------------
for cpv in trg_cache:
    cp = cpv_getkey(cpv)
    if cp is None:
            self.returncode |= 1
            writemsg_level(
                    "Unable to parse cp for '%s'\n"  % (cpv,),
                    level=logging.ERROR, noiselevel=-1)
    else:
            dead_nodes.add(cpv)
----------------------------------------------------------------

After diving deeper into the code I found the file pym/portage/cache/flat_hash.py. The __iter__ declared here uses os.listdir(), which from what I've read does not ignore dotfiles. I found a quick fix through adding an additional condition here:

-------------------------------------------------------
if l.endswith(".cpickle") or l.startswith("."):
-------------------------------------------------------

However I'm not 100% certain that this is the overall best solution with my knowledge of the portage code and wanted to get some insight. 

- Chris