| 1 |
On Fri, 2019-12-13 at 08:47 -0500, Mike Gilbert wrote: |
| 2 |
> On Thu, Dec 12, 2019 at 3:15 PM Ulrich Mueller <ulm@g.o> wrote: |
| 3 |
> > > > > > > On Thu, 12 Dec 2019, Mike Gilbert wrote: |
| 4 |
> > > I think this should be reverted. It causes too much noise, and |
| 5 |
> > > "solves" a problem only very rarely. |
| 6 |
> > |
| 7 |
> > Now, how many lines of output does this typically produce, compared |
| 8 |
> > to the total size of a typical build log? Especially with mgorny's |
| 9 |
> > subsequent modification, which suppresses the output unless the patch |
| 10 |
> > doesn't apply cleanly. |
| 11 |
> |
| 12 |
> In most cases, I would be inclined to simply ignore the patch output |
| 13 |
> since there's really no need for me to take any action on it. |
| 14 |
> |
| 15 |
> On the other hand, it makes it more difficult to quickly identify the |
| 16 |
> list of patches being applied if there is junk output in the middle of |
| 17 |
> the list. |
| 18 |
> |
| 19 |
> > It was also suggested that we add -F0 in EAPI 8, but that would break |
| 20 |
> > the build in those cases that are producing extra output now. I don't |
| 21 |
> > think that would be preferable. |
| 22 |
> |
| 23 |
> I am opposed to including such a change in EAPI 8. It would make |
| 24 |
> ebuild maintenance more difficult for everyone, and I don't think the |
| 25 |
> potential benefit is worth it. |
| 26 |
|
| 27 |
...and why do we consider it correct to apply patches when the context |
| 28 |
doesn't match? If our only goal is to make things 'easier' for |
| 29 |
'everyone', then we could just pass -F9999 and ignore all the context. |
| 30 |
|
| 31 |
Though I don't understand why include any context in the first place if |
| 32 |
you don't care about it matching. Sounds like a waste of space to me! |
| 33 |
|
| 34 |
-- |
| 35 |
Best regards, |
| 36 |
Michał Górny |
Archives