1 |
On 26-07-2022 04:01:37 +0100, Sam James wrote: |
2 |
> |
3 |
> |
4 |
> > On 26 Jul 2022, at 00:33, Mike Gilbert <floppym@g.o> wrote: |
5 |
> > |
6 |
> > On Mon, Jul 25, 2022 at 11:38 AM Fabian Groffen <grobian@g.o> wrote: |
7 |
> >> |
8 |
> >> bin/install-qa-check.d/80libraries: support Darwin/Mach-O objects |
9 |
> >> |
10 |
> >> Check for dylib on Darwin, so on everything else. |
11 |
> >> |
12 |
> >> Signed-off-by: Fabian Groffen <grobian@g.o> |
13 |
> >> |
14 |
> >> diff --git a/bin/install-qa-check.d/80libraries b/bin/install-qa-check.d/80libraries |
15 |
> >> index 8dc35bb87..a477ec9cb 100644 |
16 |
> >> --- a/bin/install-qa-check.d/80libraries |
17 |
> >> +++ b/bin/install-qa-check.d/80libraries |
18 |
> >> @@ -140,7 +140,9 @@ lib_check() { |
19 |
> >> local abort="no" |
20 |
> >> local a s |
21 |
> >> for a in "${ED%/}"/usr/lib*/*.a ; do |
22 |
> >> - s=${a%.a}.so |
23 |
> >> + [[ ${CHOST} == *-darwin* ]] \ |
24 |
> >> + && s=${a%.a}.dylib \ |
25 |
> >> + || s=${a%.a}.so |
26 |
> > |
27 |
> > I would find this much easier to read if you converted it to an |
28 |
> > if/else statement instead of chaining && and ||. |
29 |
> |
30 |
> Yes, please. |
31 |
|
32 |
https://github.com/gentoo/portage/pull/867 |
33 |
|
34 |
Thanks |
35 |
|
36 |
|
37 |
-- |
38 |
Fabian Groffen |
39 |
Gentoo on a different level |