| 1 |
On 09/02/2017 12:10 PM, Michał Górny wrote: |
| 2 |
> Update the description for --bug and --closes to account for the fact |
| 3 |
> that the tags are now handled by git hooks on Gentoo Infra, and cause |
| 4 |
> actions on Gentoo Bugzilla. |
| 5 |
> |
| 6 |
> // NB: It would probably make sense for --closes to default to Gentoo |
| 7 |
> bug numbers now. However, I have doubts that some people might have |
| 8 |
> already started using it for pull requests, and that might cause |
| 9 |
> confusion. What do you think? |
| 10 |
|
| 11 |
Yeah it's hard do say, maybe add a --closes-bug option for gentoo bugs? |
| 12 |
|
| 13 |
> --- |
| 14 |
> repoman/man/repoman.1 | 11 +++++++---- |
| 15 |
> 1 file changed, 7 insertions(+), 4 deletions(-) |
| 16 |
> |
| 17 |
> diff --git a/repoman/man/repoman.1 b/repoman/man/repoman.1 |
| 18 |
> index a49c72c0d..4b518e6f1 100644 |
| 19 |
> --- a/repoman/man/repoman.1 |
| 20 |
> +++ b/repoman/man/repoman.1 |
| 21 |
> @@ -27,13 +27,16 @@ be either a Gentoo bug number or a full bug URL (either Gentoo |
| 22 |
> or upstream). Gentoo bug URLs are automatically shortened to |
| 23 |
> the canonical \fBhttps://bugs.gentoo.org/NNNNNN\fR form, and HTTPS |
| 24 |
> is forced for known bug trackers. |
| 25 |
> + |
| 26 |
> +When pushing to the Gentoo repository, the reference to the commit |
| 27 |
> +will be automatically added as a comment on the bug. |
| 28 |
> .TP |
| 29 |
> \fB-c\fR, \fB--closes\fR |
| 30 |
> Include a \fBCloses\fR tag in the commit message footer that can be used |
| 31 |
> -to close pull requests (and issues) on GitHub and other compatible |
| 32 |
> -services (GitLab, Bitbucket). The argument can be either a PR number for |
| 33 |
> -the gentoo/gentoo GitHub repository or a full PR/bug URL. For bug URLs, |
| 34 |
> -HTTPS is forced automatically for known bug/PR trackers. |
| 35 |
> +to close bugs and pull requests (e.g. on Gentoo Bugzilla, GitHub, GitLab, |
| 36 |
> +Bitbucket). The argument can be either a PR number for the gentoo/gentoo |
| 37 |
> +GitHub repository or a full PR/bug URL. For bug URLs, HTTPS is forced |
| 38 |
> +automatically for known bug/PR trackers. |
| 39 |
> .TP |
| 40 |
> \fB\-\-digest=<y|n>\fR |
| 41 |
> Automatically update Manifest digests for modified files. This |
| 42 |
> |
| 43 |
|
| 44 |
Looks good. |
| 45 |
-- |
| 46 |
Thanks, |
| 47 |
Zac |
Archives