Re: [gentoo-portage-dev] [PATCH 3/3] DEVELOPING: Add note on commit messages

[Brian Dolbec]

On Thu, 27 Mar 2014 13:48:40 +0100
Alexander Berntsen <bernalex@g.o> wrote:

> ---
>  DEVELOPING | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/DEVELOPING b/DEVELOPING
> index c6004ec..a34dda5 100644
> --- a/DEVELOPING
> +++ b/DEVELOPING
> @@ -175,6 +175,26 @@ change a lot of unrelated things.  This makes it
> easier to see what parts of the system have actually changed.  It
> also makes it easier to cherry-pick and revert commits. Use your
> commonsense!
> +Commit messages
> +---------------
> +
> +Commit messages should be in the imperative mood with a capitalised
> +header, optionally followed by a newline and a more detailed
> explanatory +text.  The headline should be capped at 50 characters,
> the detailed text +at 72.  Prefix the message with the component you
> touched if this makes +sense.  Postfix the message with the bug it
> fixes, if it does.  Example: +
> +"
> +emerge: Fix --tree output (#555555)
> +
> +Make sure newlines appear where they are supposed to. Fix a bug with
> +colourisation of --tree output when used in tandem with --verbose
> +--pretend --ask.
> +"
> +
> +For a more detailed explanation (and rationalisation) of these rules:
> +<http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html>
> +
>  Releases
>  --------
>

No, Willikins works with Bug 555555, not #555555.

so stick with (bug 555555) format

or if your worried about the space since bug is 2 char. longer than #,
drop the 2 () characters. It'll be the same length so:

+emerge: Fix --tree output bug 555555


-- 
Brian Dolbec <dolsen>