| 1 |
-----BEGIN PGP SIGNED MESSAGE----- |
| 2 |
Hash: SHA1 |
| 3 |
|
| 4 |
On 01/12/2014 03:57 PM, Jesus Rivero (Neurogeek) wrote: |
| 5 |
> Hi all, |
| 6 |
> |
| 7 |
> In the previous patch, I didn't notice an error in the unittest I |
| 8 |
wrote for the feature. |
| 9 |
> Attached is the correct patch, please disregard the previous one. |
| 10 |
> |
| 11 |
> Cheers, |
| 12 |
> |
| 13 |
> Jesus Rivero |
| 14 |
|
| 15 |
Neurogeek, |
| 16 |
|
| 17 |
Looks like we were working on the same patch, but I guess the patch is a |
| 18 |
good exercise in getting familiar with the portage code :P |
| 19 |
|
| 20 |
Overall it looks good. There were some complaints from git apply about |
| 21 |
trivial spacing issues (trailing whitespace), and there's a space |
| 22 |
included in indentation that causes python 3.3 to fail: |
| 23 |
|
| 24 |
0002-Added-support-for-variable-expansion-in-source-commandd.patch:61: |
| 25 |
space before tab in indent. |
| 26 |
|
| 27 |
I'm not sure if it matters, but your code seems to do variable expansion |
| 28 |
for the source command even if the 'expand' variable in the getconfig() |
| 29 |
function is set to False (unless I'm wrong?). |
| 30 |
|
| 31 |
All, |
| 32 |
|
| 33 |
Although neurogeek already sent a patch, I figured I'd include mine as |
| 34 |
well at the request of dol-sen :) |
| 35 |
|
| 36 |
This patch does not include unit tests since it's meant to be more of a |
| 37 |
review against neurogeek's code. |
| 38 |
|
| 39 |
Regards, |
| 40 |
Pavel |
| 41 |
-----BEGIN PGP SIGNATURE----- |
| 42 |
Version: GnuPG v2.0.22 (GNU/Linux) |
| 43 |
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
| 44 |
|
| 45 |
iQIcBAEBAgAGBQJS04RiAAoJENb1ecI556suiyYP/1X+CXK+WFoURBPUOlOyw9bN |
| 46 |
jKYg5My7wcz07VnWrIkPiuQf3Pq3bj2ckMc54kiL59bMWQgMXjtZMJzyzfegza/t |
| 47 |
Ks22+RYxmwdwU9OJ9prknFMLXdibEqT4zBk0MxHHfNeHqJtDM7j2Nc3Xcj+jP93R |
| 48 |
zRFzFLjWjOeT4kCzUvmnEewjd9WlhycAhXB/MMoEQM/stAROv9sai7RhF+6EpXsE |
| 49 |
XRP3ZagCdni5YA/Gz+eWZ59rihgo/8X1RLMzoK3MmPmh+LEi1Eop8NaHeTT4FumP |
| 50 |
4ftr4mtc84qUpeo+pzzgi40Dse08oaHXCu5IX5lkVh0/Uu2vvVieTORGpLtDv9Mk |
| 51 |
sK2qCZJ9JQU8l3pE2tRVkZ935IN/DxDoUCt5EosOB5OQ3UG6RkIP+hqNmcpkA6wC |
| 52 |
OENrV5LCkAGzyuUNOCgqy4sL/rHWpSD+DqToc54vsnWTdkBCYO31AtwSKQ1xkihK |
| 53 |
gp3Re+7Z6dA6KhjF5ZM6LOd5KyH6gbEH2EqtEuWeNiaeBB+5eYJuhLiqVOrmfgkl |
| 54 |
nnatebh2DQum52OFDX4Q2M+6Cp0OHuYHUL0HxHcPRzmTnqBkwJtTxFoe2v3nQr5U |
| 55 |
cTTrkM8t0TD7/CqHTo0JQQBleIEQGaI3jzHBaOS1DWxU4ZXaTbBrq8gng3H7RVW/ |
| 56 |
3mbx448SfEyeNGFiZqzE |
| 57 |
=g+z5 |
| 58 |
-----END PGP SIGNATURE----- |
Archives