Gentoo Archives: gentoo-portage-dev

From: Alexander Berntsen <bernalex@g.o>
To: Doug Goldstein <cardoe@××××××.com>, gentoo-portage-dev@l.g.o, dev-portage@g.o
Cc: Brian Dolbec <dolsen@g.o>, Zac Medico <zmedico@g.o>
Subject: [gentoo-portage-dev] Re: [PATCH v2] Change how the tmp file for the commit msg is made (bug 571546)
Date: Mon, 23 May 2016 10:43:22
Message-Id: 5742DEB8.4010609@gentoo.org
1 -----BEGIN PGP SIGNED MESSAGE-----
2 Hash: SHA512
3
4 I see you have incorporated Zac's feedback by using shutil. You have
5 also incorporated my feedback on the commit message. I forgot to say
6 that the message body should also begin in the imperative mood, so it
7 should be "Change" not "Changes". But that's OK, we can just change
8 this when we merge it. My bad.
9
10 The patch still looks OK to my eyes. I will leave it to Brian to ack,
11 as repoman has been his baby these past months. (Brian, I can merge it
12 if you don't have the time, but please give an ack.)
13 - --
14 Alexander
15 bernalex@g.o
16 https://secure.plaimi.net/~alexander
17 -----BEGIN PGP SIGNATURE-----
18 Version: GnuPG v2
19
20 iQIcBAEBCgAGBQJXQt64AAoJENQqWdRUGk8BksQP/iV301h2bP32hHeAh0e+YUHH
21 NmUvwx1KSAnAjaL28rTEE8LzJcy+QDTdwhW9Y9x7gUD0fWeUuQpMXEnIQ7DIVmm/
22 XfNI8M9bey90VLa8VNzIkfpHqeb5asvkHSLlyVVCb/BcE/wR23peRdW4F9LAhrAs
23 0Mdz+g09Bjb5SawiTyaNig+YSid8MDWTDI+6oskB8NAhyaDqaUKGk/HfGqAG95FW
24 lbXIBE4dIQ2jFdzyn+3/rXWXBVCuXL1OufQPSiIFwfsU4j957SRo/cYlDqXyyQXD
25 mXXju2fU3cEk16Po+7v9wNp77xu2HdML7jgO75HdSDN5eDMJ3gyFlrlLw1Ztw9OA
26 v4+IXcbgGEGguN4Tz+DuY1+htGRnjBR5C2dj6y6rZU9HbIMTzJSxI/rQQUsQJ53j
27 Nd6++GJXqpskDhd+Zx1Gmhj5yV/h7Nc/YDUsT6CTsLNOzVJUy6acyhWqJRt46MAs
28 9nw1c9xqoGLhCiWvAK5PZOz4/cfEUtEawUrQg4wtoPap05qzMx8fsk3rX9J7ifrq
29 rQlBVxwGQqjN9ykzDl2IkY8/W9sx8Nhe5/M5rmUCsk0KUzhcrkQNCOHdzSSU2jSM
30 Yimj4y+gBnizHIVn2+sAZ4vosTXic/zVKi5meYgSM4pBRAwD4GJgQ5vV//cWTTZl
31 6QTa+hD/NQZAQd14COhc
32 =9N4L
33 -----END PGP SIGNATURE-----

Replies