Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH] repoman: Add commit message verification
Date: Sun, 04 Feb 2018 20:03:16
Message-Id: 1517774588.12257.2.camel@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH] repoman: Add commit message verification by Ulrich Mueller
1 W dniu sob, 03.02.2018 o godzinie 09∶58 +0100, użytkownik Ulrich Mueller
2 napisał:
3 > > > > > > On Fri, 2 Feb 2018, Michał Górny wrote:
4 > > Add a check for common mistakes in commit messages. For now, it is
5 > > pretty rough and exits immediately but it should be integrated with
6 > > the editor in the future.
7 >
8 > Have you tested this against existing commits in the gentoo repo?
9 >
10
11 After checking the 10000 most recent commits, I have the following stats
12 on invalid commit messages:
13
14 138 klausman@g.o
15 99 slyfox@g.o
16 61 leio@g.o
17 20 dilfridge@g.o
18 18 monsieurp@g.o
19 15 pacho@g.o
20 15 whissi@g.o
21 13 alicef@g.o
22 12 floppym@g.o
23 12 xmw@g.o
24 12 jer@g.o
25 11 axs@g.o
26 11 amynka@g.o
27 10 polynomial-c@g.o
28 ...
29
30 Most of the violations are uses of Gentoo-Bug and very long single-line
31 commit messages; most likely people using '-m "very long message because
32 I am lazy and can't use editor properly"'.
33
34 Full list of violations in the sample:
35 https://gist.github.com/mgorny/fa81ffe07ca9565198e4e44fb040bb19
36
37 --
38 Best regards,
39 Michał Górny

Replies