| 1 |
On Tue, Aug 16, 2005 at 02:39:36PM -0400, Alec Joseph Warner wrote: |
| 2 |
> I kind of see Brian's point in being defensive in filenames though |
| 3 |
> (os.path.normpath("///////var/db/pkg/fex") being invalid in a CONTENTS |
| 4 |
> file but still usable by most(?) calls in python, which will just figure |
| 5 |
> it all out anyway. |
| 6 |
If we aren't defensive on it, and it causes something to implode, it's |
| 7 |
a runtime bt... |
| 8 |
Re: equery, equery is a special case walking the entire contents... |
| 9 |
|
| 10 |
> If portage errored on invalid paths in CONTENTS file, I would see |
| 11 |
> leaving it there, but if it doesn't help anything ( because it doesn't |
| 12 |
> hurt anything either, right? :) ) then why do the work? |
| 13 |
What about finding a faster approach then normpath? |
| 14 |
|
| 15 |
Take a look at normpath, it splits it up into strings, and rejoins; |
| 16 |
that's a bit of a hit right there- potential point for optimization if |
| 17 |
I keep screaming "the data returned may not be right, albeit usable" |
| 18 |
:) |
| 19 |
~harring |
Archives