1 |
Print single ">>> Syncing repository '%s' into '%s'..." before syncing, |
2 |
and single "=== Sync completed for %s" after successful sync. |
3 |
|
4 |
Remove duplicate in-module clone/pull messages. Instead, verbosely print |
5 |
git commands executed. |
6 |
|
7 |
Remove useless verbosity in pre-sync mkdir. |
8 |
--- |
9 |
pym/portage/sync/controller.py | 8 +++++--- |
10 |
pym/portage/sync/modules/cvs/cvs.py | 6 ------ |
11 |
pym/portage/sync/modules/git/git.py | 31 +++++++++++------------------ |
12 |
pym/portage/sync/modules/rsync/rsync.py | 2 +- |
13 |
pym/portage/sync/modules/svn/svn.py | 6 ------ |
14 |
pym/portage/sync/modules/websync/websync.py | 6 ------ |
15 |
6 files changed, 18 insertions(+), 41 deletions(-) |
16 |
|
17 |
diff --git a/pym/portage/sync/controller.py b/pym/portage/sync/controller.py |
18 |
index 3d217db..128a38e 100644 |
19 |
--- a/pym/portage/sync/controller.py |
20 |
+++ b/pym/portage/sync/controller.py |
21 |
@@ -156,6 +156,10 @@ class SyncManager(object): |
22 |
#print("result:", result, "callback()", self.callback) |
23 |
exitcode, updatecache_flg = result |
24 |
self.exitcode = exitcode |
25 |
+ if exitcode == 0: |
26 |
+ msg = "=== Sync completed for %s" % self.repo.name |
27 |
+ self.logger(self.xterm_titles, msg) |
28 |
+ writemsg_level(msg + "\n") |
29 |
if self.callback: |
30 |
self.callback(exitcode, updatecache_flg) |
31 |
return |
32 |
@@ -184,7 +188,7 @@ class SyncManager(object): |
33 |
def pre_sync(self, repo): |
34 |
self.settings, self.trees, self.mtimedb = self.emerge_config |
35 |
self.xterm_titles = "notitles" not in self.settings.features |
36 |
- msg = ">>> Synchronization of repository '%s' located in '%s'..." \ |
37 |
+ msg = ">>> Syncing repository '%s' into '%s'..." \ |
38 |
% (repo.name, repo.location) |
39 |
self.logger(self.xterm_titles, msg) |
40 |
writemsg_level(msg + "\n") |
41 |
@@ -255,8 +259,6 @@ class SyncManager(object): |
42 |
if 'gid' in spawn_kwargs: |
43 |
perms['gid'] = spawn_kwargs['gid'] |
44 |
|
45 |
- writemsg_level(">>> '%s' not found, creating it." |
46 |
- % _unicode_decode(repo.location)) |
47 |
portage.util.ensure_dirs(repo.location, **perms) |
48 |
st = os.stat(repo.location) |
49 |
|
50 |
diff --git a/pym/portage/sync/modules/cvs/cvs.py b/pym/portage/sync/modules/cvs/cvs.py |
51 |
index 52d5d9a..2c3c6a3 100644 |
52 |
--- a/pym/portage/sync/modules/cvs/cvs.py |
53 |
+++ b/pym/portage/sync/modules/cvs/cvs.py |
54 |
@@ -28,9 +28,6 @@ class CVSSync(SyncBase): |
55 |
if kwargs: |
56 |
self._kwargs(kwargs) |
57 |
#initial checkout |
58 |
- msg = ">>> Starting initial cvs checkout with %s..." % self.repo.sync_uri |
59 |
- self.logger(self.xterm_titles, msg) |
60 |
- writemsg_level(msg + "\n") |
61 |
try: |
62 |
os.rmdir(self.repo.location) |
63 |
except OSError as e: |
64 |
@@ -68,9 +65,6 @@ class CVSSync(SyncBase): |
65 |
if cvs_root.startswith("cvs://"): |
66 |
cvs_root = cvs_root[6:] |
67 |
#cvs update |
68 |
- msg = ">>> Starting cvs update with %s..." % self.repo.sync_uri |
69 |
- self.logger(self.xterm_titles, msg) |
70 |
- writemsg_level(msg + "\n") |
71 |
exitcode = portage.process.spawn_bash( |
72 |
"cd %s; exec cvs -z0 -q update -dP" % \ |
73 |
(portage._shell_quote(self.repo.location),), |
74 |
diff --git a/pym/portage/sync/modules/git/git.py b/pym/portage/sync/modules/git/git.py |
75 |
index 02da037..1b138cc 100644 |
76 |
--- a/pym/portage/sync/modules/git/git.py |
77 |
+++ b/pym/portage/sync/modules/git/git.py |
78 |
@@ -57,29 +57,25 @@ class GitSync(SyncBase): |
79 |
'Created new directory %s' % self.repo.location) |
80 |
except IOError: |
81 |
return (1, False) |
82 |
- msg = ">>> Cloning git repository from upstream into %s..." % self.repo.location |
83 |
- self.logger(self.xterm_titles, msg) |
84 |
- writemsg_level(msg + "\n") |
85 |
sync_uri = self.repo.sync_uri |
86 |
if sync_uri.startswith("file://"): |
87 |
sync_uri = sync_uri[6:] |
88 |
depth_arg = '' |
89 |
if self.repo.sync_clone_depth is not None: |
90 |
depth_arg = '--depth %d ' % self.repo.sync_clone_depth |
91 |
- exitcode = portage.process.spawn_bash("cd %s ; %s clone %s%s ." % \ |
92 |
- (portage._shell_quote(self.repo.location), |
93 |
- self.bin_command, |
94 |
- depth_arg, |
95 |
- portage._shell_quote(sync_uri)), |
96 |
+ |
97 |
+ git_cmd = "%s clone %s%s ." % (self.bin_command, depth_arg, |
98 |
+ portage._shell_quote(sync_uri)) |
99 |
+ writemsg_level(git_cmd + "\n") |
100 |
+ |
101 |
+ exitcode = portage.process.spawn_bash("cd %s ; exec %s" % ( |
102 |
+ portage._shell_quote(self.repo.location), git_cmd), |
103 |
**portage._native_kwargs(self.spawn_kwargs)) |
104 |
if exitcode != os.EX_OK: |
105 |
msg = "!!! git clone error in %s" % self.repo.location |
106 |
self.logger(self.xterm_titles, msg) |
107 |
writemsg_level(msg + "\n", level=logging.ERROR, noiselevel=-1) |
108 |
return (exitcode, False) |
109 |
- msg = ">>> Git clone successful" |
110 |
- self.logger(self.xterm_titles, msg) |
111 |
- writemsg_level(msg + "\n") |
112 |
return (os.EX_OK, True) |
113 |
|
114 |
|
115 |
@@ -94,18 +90,15 @@ class GitSync(SyncBase): |
116 |
emerge_config = self.options.get('emerge_config', None) |
117 |
portdb = self.options.get('portdb', None) |
118 |
|
119 |
- msg = ">>> Starting git pull in %s..." % self.repo.location |
120 |
- self.logger(self.xterm_titles, msg) |
121 |
- writemsg_level(msg + "\n") |
122 |
- exitcode = portage.process.spawn_bash("cd %s ; git pull" % \ |
123 |
- (portage._shell_quote(self.repo.location),), |
124 |
+ git_cmd = "%s pull" % self.bin_command |
125 |
+ writemsg_level(git_cmd + "\n") |
126 |
+ |
127 |
+ exitcode = portage.process.spawn_bash("cd %s ; exec %s" % ( |
128 |
+ portage._shell_quote(self.repo.location), git_cmd), |
129 |
**portage._native_kwargs(self.spawn_kwargs)) |
130 |
if exitcode != os.EX_OK: |
131 |
msg = "!!! git pull error in %s" % self.repo.location |
132 |
self.logger(self.xterm_titles, msg) |
133 |
writemsg_level(msg + "\n", level=logging.ERROR, noiselevel=-1) |
134 |
return (exitcode, False) |
135 |
- msg = ">>> Git pull successful: %s" % self.repo.location |
136 |
- self.logger(self.xterm_titles, msg) |
137 |
- writemsg_level(msg + "\n") |
138 |
return (os.EX_OK, True) |
139 |
diff --git a/pym/portage/sync/modules/rsync/rsync.py b/pym/portage/sync/modules/rsync/rsync.py |
140 |
index b2fb2f8..52d8b0f 100644 |
141 |
--- a/pym/portage/sync/modules/rsync/rsync.py |
142 |
+++ b/pym/portage/sync/modules/rsync/rsync.py |
143 |
@@ -246,7 +246,7 @@ class RsyncSync(SyncBase): |
144 |
|
145 |
def _process_exitcode(self, exitcode, syncuri, out, maxretries): |
146 |
if (exitcode==0): |
147 |
- self.logger(self.xterm_titles, "=== Sync completed with %s" % syncuri) |
148 |
+ pass |
149 |
elif exitcode == SERVER_OUT_OF_DATE: |
150 |
exitcode = 1 |
151 |
elif exitcode == EXCEEDED_MAX_RETRIES: |
152 |
diff --git a/pym/portage/sync/modules/svn/svn.py b/pym/portage/sync/modules/svn/svn.py |
153 |
index 0365e90..73c4b83 100644 |
154 |
--- a/pym/portage/sync/modules/svn/svn.py |
155 |
+++ b/pym/portage/sync/modules/svn/svn.py |
156 |
@@ -28,9 +28,6 @@ class SVNSync(SyncBase): |
157 |
if kwargs: |
158 |
self._kwargs(kwargs) |
159 |
#initial checkout |
160 |
- msg = ">>> Starting initial svn checkout with %s..." % self.repo.sync_uri |
161 |
- self.logger(self.xterm_titles, msg) |
162 |
- writemsg_level(msg + "\n") |
163 |
try: |
164 |
os.rmdir(self.repo.location) |
165 |
except OSError as e: |
166 |
@@ -71,9 +68,6 @@ class SVNSync(SyncBase): |
167 |
if svn_root.startswith("svn://"): |
168 |
svn_root = svn_root[6:] |
169 |
#svn update |
170 |
- msg = ">>> Starting svn update with %s..." % self.repo.sync_uri |
171 |
- self.logger(self.xterm_titles, msg) |
172 |
- writemsg_level(msg + "\n") |
173 |
exitcode = portage.process.spawn_bash( |
174 |
"cd %s; exec svn update" % \ |
175 |
(portage._shell_quote(self.repo.location),), |
176 |
diff --git a/pym/portage/sync/modules/websync/websync.py b/pym/portage/sync/modules/websync/websync.py |
177 |
index f08ae77..0ad4efb 100644 |
178 |
--- a/pym/portage/sync/modules/websync/websync.py |
179 |
+++ b/pym/portage/sync/modules/websync/websync.py |
180 |
@@ -38,9 +38,6 @@ class WebRsync(SyncBase): |
181 |
emerge_config = self.options.get('emerge_config', None) |
182 |
portdb = self.options.get('portdb', None) |
183 |
|
184 |
- msg = ">>> Starting emerge-webrsync for %s..." % self.repo.location |
185 |
- self.logger(self.xterm_titles, msg) |
186 |
- writemsg_level(msg + "\n") |
187 |
exitcode = portage.process.spawn_bash("%s" % \ |
188 |
(self.bin_command), |
189 |
**portage._native_kwargs(self.spawn_kwargs)) |
190 |
@@ -49,9 +46,6 @@ class WebRsync(SyncBase): |
191 |
self.logger(self.xterm_titles, msg) |
192 |
writemsg_level(msg + "\n", level=logging.ERROR, noiselevel=-1) |
193 |
return (exitcode, False) |
194 |
- msg = ">>> Emerge-webrsync successful: %s" % self.repo.location |
195 |
- self.logger(self.xterm_titles, msg) |
196 |
- writemsg_level(msg + "\n") |
197 |
#return self.post_sync(portdb, self.repo.location, emerge_config) |
198 |
return (exitcode, True) |
199 |
|
200 |
-- |
201 |
2.2.1 |