| 1 |
On Fri, 2010-04-23 at 22:31 -0700, Zac Medico wrote: |
| 2 |
> On 04/23/2010 05:43 AM, Sebastian Luther wrote: |
| 3 |
> > Someone might come up with some logic to detect new use flags in |
| 4 |
> > *DEPEND, but this looks like a hack to me. |
| 5 |
> |
| 6 |
> It doesn't seem too bad to me. |
| 7 |
> |
| 8 |
> > The clean solution is to |
| 9 |
> > store the unevaluated string. |
| 10 |
> |
| 11 |
> Do you want to do this for $PKGDIR/Packages as well? We've always |
| 12 |
> evaluated USE conditionals in there since we were copying the |
| 13 |
> behavior of the older genpkgindex tool and that's how it behaved. |
| 14 |
> |
| 15 |
> Also note that if we want to rely on having unevaluated strings then |
| 16 |
> we'll probably want to try to get alternative package managers to |
| 17 |
> behave the same way (maybe specify it in PMS). |
| 18 |
> |
| 19 |
> > Question is: Does anyone have a good argument to not use the old |
| 20 |
> > behavior again? |
| 21 |
|
| 22 |
space and ease of parsing for minimal pkg mergers. |
| 23 |
|
| 24 |
|
| 25 |
> > |
| 26 |
> > Sebastian |
| 27 |
> > |
| 28 |
> > [1] commit e6be6590e99522f9be69e2af8eff87919d9bf31f on 2010-02-14 |
| 29 |
> |
| 30 |
> I think we'll have to handle the evaluated strings anyway since this |
| 31 |
> code has already been released and stabilized in portage-2.1.8.x, |
| 32 |
> and USE conditionals have been evaluate in $PKGDIR/Packages for even |
| 33 |
> longer. Because of this, I see little or no benefit in changing it |
| 34 |
> back to unevaluated strings at this point. |
| 35 |
|
| 36 |
Good. Thanks for not reverting back to those old behaviors. |
Archives