Re: [gentoo-portage-dev] [PATCH] sync: call git prune before shallow fetch (bug 599008)

[Michał Górny]

On Sat,  5 Nov 2016 13:43:15 -0700
Zac Medico <zmedico@g.o> wrote:

> This is necessary in order to avoid "There are too many unreachable
> loose objects" warnings from automatic git gc calls.
>
> X-Gentoo-Bug: 599008
> X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=599008
> ---
>  pym/portage/sync/modules/git/git.py | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/pym/portage/sync/modules/git/git.py b/pym/portage/sync/modules/git/git.py
> index f288733..c90cf88 100644
> --- a/pym/portage/sync/modules/git/git.py
> +++ b/pym/portage/sync/modules/git/git.py
> @@ -101,6 +101,12 @@ class GitSync(NewBase):
>  				writemsg_level(msg + "\n", level=logging.ERROR, noiselevel=-1)
>  				return (e.returncode, False)
>
> +			# For shallow fetch, unreachable objects must be pruned
> +			# manually, since otherwise automatic git gc calls will
> +			# eventually warn about them (see bug 599008).
> +			subprocess.call(['git', 'prune'],
> +				cwd=portage._unicode_encode(self.repo.location))
> +
>  			git_cmd_opts += " --depth %d" % self.repo.sync_depth
>  			git_cmd = "%s fetch %s%s" % (self.bin_command,
>  				remote_branch.partition('/')[0], git_cmd_opts)

Does it have a performance impact?

-- 
Best regards,
Michał Górny