Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: Michael Orlitzky <mjo@g.o>, gentoo-portage-dev@l.g.o
Cc: Zac Medico <zmedico@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH v3 1/2] bin/install-qa-check.d: add new 90bad-bin-owner QA check.
Date: Tue, 07 Aug 2018 18:52:19
Message-Id: 0f5eb60a-e8ca-831d-3115-e25b4193523e@gentoo.org
In Reply to: Re: [gentoo-portage-dev] [PATCH v3 1/2] bin/install-qa-check.d: add new 90bad-bin-owner QA check. by Michael Orlitzky
1 On 08/07/2018 10:44 AM, Michael Orlitzky wrote:
2 > On 08/07/2018 01:34 PM, Zac Medico wrote:
3 >>
4 >> Why not use ${ED%/} instead of ${D%/} here, so that the output is the
5 >> same regardless of ${EPREFIX}?
6 >>
7 >
8 > We want to show where the executable was actually installed, and
9 > generally that includes EPREFIX. For example, I'd want to see
10 >
11 > /var/tmp/whatever/.../root/prefix/usr/bin/foo
12 >
13 > reported as
14 >
15 > /root/prefix/usr/bin/foo
16 >
17 > rather than
18 >
19 > /usr/bin/foo
20 >
21 > Of course, these checks are now skipped on prefix systems anyway, so
22 > it's a bit of a moot point. But I think it's more future-proof to strip
23 > only the $D.
24
25 Sounds good. Thanks! Merged:
26
27 https://gitweb.gentoo.org/proj/portage.git/commit/?id=807ac3d9d6eecead73f59d399b30559e5c731587
28 --
29 Thanks,
30 Zac

Attachments

File name MIME type
signature.asc application/pgp-signature