| 1 |
On Fri, Mar 24, 2017 at 1:05 PM, Brian Dolbec <dolsen@g.o> wrote: |
| 2 |
> On Thu, 23 Mar 2017 19:55:00 -0700 |
| 3 |
> Zac Medico <zmedico@g.o> wrote: |
| 4 |
> |
| 5 |
>> Add a terminate method to FetchIterator so that it doesn't |
| 6 |
>> delay termination of emirrordist via SIGINT. Otherwise it |
| 7 |
>> it is possible for the __iter__ method to loop for a very |
| 8 |
>> long time after SIGINT has been delivered. For example, |
| 9 |
>> this could happen if there are many ebuilds with stale |
| 10 |
>> cache and RESTRICT=mirror. This issue was discovered |
| 11 |
>> during testing of changes to the MirrorDistTask.terminate |
| 12 |
>> implementation. |
| 13 |
>> --- |
| 14 |
>> pym/portage/_emirrordist/FetchIterator.py | 21 +++++++++++++++++++++ |
| 15 |
>> pym/portage/_emirrordist/MirrorDistTask.py | 6 +++++- |
| 16 |
>> 2 files changed, 26 insertions(+), 1 deletion(-) |
| 17 |
>> |
| 18 |
> |
| 19 |
> Not that I know enough about all this that I could say "your doing it |
| 20 |
> wrong" |
| 21 |
> |
| 22 |
> But the series looks OK, I didn't see any obvious goofs ;) |
| 23 |
> |
| 24 |
> Thanks |
| 25 |
|
| 26 |
Thanks, pushed: |
| 27 |
|
| 28 |
https://gitweb.gentoo.org/proj/portage.git/commit/?id=04b1012594bfad1be719547e2c88a2dcf1051dc1 |
| 29 |
https://gitweb.gentoo.org/proj/portage.git/commit/?id=86400e9f864e86f8f677ccda9ce4103d6d02ef87 |
| 30 |
https://gitweb.gentoo.org/proj/portage.git/commit/?id=61878e4fbdfef5f8512b34640089e954a14e6d12 |
| 31 |
https://gitweb.gentoo.org/proj/portage.git/commit/?id=7defd54354c17afce7f36f53431260c1909481be |
| 32 |
https://gitweb.gentoo.org/proj/portage.git/commit/?id=f70db92cba82535c8f65d385bd08a40207e24ec1 |
| 33 |
-- |
| 34 |
Thanks, |
| 35 |
Zac |
Archives