Archives
Archives
| From: | Alec Warner <antarus@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH v3] Test for read-only filesystems, bail out during preinst if there are any which will be written to and display a useful error message. Fixes bug 378869. | ||
| Date: | Sun, 19 Jan 2014 21:43:40 | ||
| Message-Id: | CAAr7Pr-CpFuB1zswG64bveJMxXLgtH06_BkNmkoOXn29veynyg@mail.gmail.com | ||
| In Reply to: | Re: [gentoo-portage-dev] [PATCH v3] Test for read-only filesystems, bail out during preinst if there are any which will be written to and display a useful error message. Fixes bug 378869. by Alexander Berntsen |
||
| 1 | On Sun, Jan 19, 2014 at 2:39 AM, Alexander Berntsen <alexander@××××××.net>wrote: |
| 2 | |
| 3 | > -----BEGIN PGP SIGNED MESSAGE----- |
| 4 | > Hash: SHA256 |
| 5 | > |
| 6 | > On 19/01/14 10:17, Mike Frysinger wrote: |
| 7 | > > prefer OSes -> OS's |
| 8 | > That's just not proper English. It makes no sense. Please don't prefer |
| 9 | > that. If for nothing else, then to prevent me from sighing whenever I |
| 10 | > have to read it. |
| 11 | > |
| 12 | |
| 13 | The bikeshed should be red! Be happy in the fact that this bit has no |
| 14 | significant bearing on the code and just pick one. |
| 15 | |
| 16 | |
| 17 | > > not a new issue, but we really need to get away from this style and |
| 18 | > > use PEP257. someone feel like fixing that in the code base ? :) |
| 19 | > I agree. If you give me at least a week (won't have time until next |
| 20 | > weekend), I can look into it. |
| 21 | > |
| 22 | |
| 23 | Sorry, my fault. I added docstrings in 2006 (looks like the first one was |
| 24 | vercmp in |
| 25 | http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=blobdiff;f=pym/portage_versions.py;h=8e58c2f47766c0ed6c007c0cba1fccebca7d4eb4;hp=ec01773ad199a87d7906eb3862a14b9c8102fc29;hb=cfc497009e6054a5403461be676bb94deebbbf50;hpb=53f14db70339391fb13ca0adab353645f84be3f2) |
| 26 | I'm happy for these to change. ;p |
| 27 | |
| 28 | -A |
| 29 | |
| 30 | |
| 31 | |
| 32 | > - -- |
| 33 | |
| 34 | Alexander |
| 35 | > alexander@××××××.net |
| 36 | > http://plaimi.net/~alexander |
| 37 | > -----BEGIN PGP SIGNATURE----- |
| 38 | > Version: GnuPG v2.0.22 (GNU/Linux) |
| 39 | > Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ |
| 40 | > |
| 41 | > iF4EAREIAAYFAlLbq10ACgkQRtClrXBQc7U7MAD/Yl2pd0ood3UKmvNMg9gdWMsw |
| 42 | > hQqnReHPRwLpDNRccOcA/jUODDanycVmNLpD/rjkYnKyllnbUSIxduYuMcJFqXme |
| 43 | > =vaDs |
| 44 | > -----END PGP SIGNATURE----- |
| 45 | > |
| 46 | > |