1 |
On 04/21/2015 10:27 AM, Zac Medico wrote: |
2 |
> On 04/21/2015 02:48 AM, Duncan wrote: |
3 |
>> Zac Medico posted on Mon, 20 Apr 2015 17:37:15 -0700 as excerpted: |
4 |
>> |
5 |
>>> On 04/20/2015 05:31 PM, Bertrand Jacquin wrote: |
6 |
>>>> On 21/04/2015 00:39, Zac Medico wrote: |
7 |
>>>>> These are in the master branch now: |
8 |
>>>>> |
9 |
>>>>> https://gitweb.gentoo.org/proj/portage.git/commit/? |
10 |
>> id=5a1b870fe54ac06f864a648c3ea5cc118f6ce911 |
11 |
>>>>> |
12 |
>>>>> https://gitweb.gentoo.org/proj/portage.git/commit/? |
13 |
>> id=e74e2670e3f043608fced9847e54bdbb19f35169 |
14 |
>>>>> |
15 |
>>>> |
16 |
>>>> Thanks for that :) |
17 |
>>>> |
18 |
>>>>> I modified the test as follows in order to ensure that it still works |
19 |
>>>>> with shell globs: |
20 |
>>>>> |
21 |
>>>>> if [[ -e "${root}"/${no_inst} || "${root}"/${no_inst} != $(echo |
22 |
>>>>> "${root}"/${no_inst}) ]] ; then |
23 |
>>>> |
24 |
>>>> I do not really understand the use case here, do you have an example ? |
25 |
>>>> |
26 |
>>>> Cheers, |
27 |
>>>> |
28 |
>>> |
29 |
>>> Well, I don't use INSTALL_MASK myself, so I don't have a real-world |
30 |
>>> use-case for you. However, it's clear that the code will expand shell |
31 |
>>> globs, so I preserved that behavior for compatibility. |
32 |
>> |
33 |
>> I do, with shell globs, tho I didn't bother checking the above to see if |
34 |
>> they'd have been affected. |
35 |
>> |
36 |
>> The two install-masks with globs I use here are: |
37 |
>> |
38 |
>> *.la |
39 |
> |
40 |
> Since it doesn't have an absolute path, this glob is handled by the |
41 |
> find/rm code which comes just after the shell glob code that I was |
42 |
> talking about. |
43 |
> |
44 |
>> (Unmasked on libtool itself, since it has a *.la file that other |
45 |
>> package's .configure scripts test for.) |
46 |
>> |
47 |
>> /etc/cron.*/ |
48 |
>> |
49 |
>> (I use systemd's timers in place of cron and thus crontablets.) |
50 |
> |
51 |
> This is absolute, so it is handled by the shell glob code in question. |
52 |
> |
53 |
|
54 |
Oh, I see what you mean now. It's reconciled by a temporary 'set -o |
55 |
noglob', followed by 'set +o noglob'. |
56 |
|
57 |
-- |
58 |
Thanks, |
59 |
Zac |