Archives
Archives
| From: | Zac Medico <zmedico@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH] emerge --info: Check metadata/timestamp.chk in all repositories | ||
| Date: | Sat, 13 Dec 2014 18:43:18 | ||
| Message-Id: | 548C88C2.4030601@gentoo.org | ||
| In Reply to: | [gentoo-portage-dev] [PATCH] emerge --info: Check metadata/timestamp.chk in all repositories by Arfrever Frehtes Taifersar Arahesis |
||
| 1 | On 12/13/2014 09:33 AM, Arfrever Frehtes Taifersar Arahesis wrote: |
| 2 | > [[[ |
| 3 | > emerge --info: Check metadata/timestamp.chk in all repositories. |
| 4 | > |
| 5 | > 1 use of deprecated PORTDIR has been deleted. |
| 6 | > ]]] |
| 7 | > |
| 8 | > -- |
| 9 | > Arfrever Frehtes Taifersar Arahesis |
| 10 | > |
| 11 | |
| 12 | LGTM. |
| 13 | |
| 14 | However, I dislike the os.path.isfile() call, because it's a redundant |
| 15 | stat call. Can't we just call grabfile, and ignore any exception that it |
| 16 | may raise? |
| 17 | -- |
| 18 | Thanks, |
| 19 | Zac |