Gentoo Archives: gentoo-portage-dev

From: Sebastian Luther <SebastianLuther@×××.de>
To: gentoo-portage-dev@l.g.o
Subject: Re: [gentoo-portage-dev] [PATCH 1/2] As per bug #472104 add option --verbose-slot-rebuilds=y|n
Date: Sun, 23 Feb 2014 17:32:03
Message-Id: 530A308A.8000309@gmx.de
In Reply to: [gentoo-portage-dev] [PATCH 1/2] As per bug #472104 add option --verbose-slot-rebuilds=y|n by Brian Dolbec
1 Am 23.02.2014 09:07, schrieb Brian Dolbec:
2 > ---
3 > pym/_emerge/actions.py | 5 +++++
4 > pym/_emerge/depgraph.py | 5 +++--
5 > pym/_emerge/main.py | 5 +++++
6 > pym/portage/package/ebuild/config.py | 3 +++
7 > 4 files changed, 16 insertions(+), 2 deletions(-)
8 >
9 > diff --git a/pym/_emerge/actions.py b/pym/_emerge/actions.py
10 > index 95c5c14..a3f7813 100644
11 > --- a/pym/_emerge/actions.py
12 > +++ b/pym/_emerge/actions.py
13 > @@ -2923,6 +2923,11 @@ def adjust_config(myopts, settings):
14 > settings["PORTAGE_VERBOSE"] = "1"
15 > settings.backup_changes("PORTAGE_VERBOSE")
16 >
17 > + if ("--verbose-slot-rebuilds" in myopts and
18 > + myopts["--verbose-slot-rebuilds"] not in ("y","True")):
19 > + settings["VERBOSE_SLOT_REBUILDS"] = "0"
20 > + settings.backup_changes("VERBOSE_SLOT_REBUILDS")
21
22 Why do you put that into the config class? In the resolver you should
23 just do:
24 if "--verbose-slot-rebuilds" in self._frozen_config.myopts:
25
26 Otherwise looks good.

Replies