| 1 |
On 9/4/20 8:39 AM, Florian Schmaus wrote: |
| 2 |
> On 9/3/20 7:57 PM, Florian Schmaus wrote: |
| 3 |
>> + systemd_profile_env_path = os.path.join(systemd_environment_dir, |
| 4 |
>> + "10-gentoo-profile-env.conf") |
| 5 |
>> + with open(systemd_profile_env_path, "w") as systemd_profile_env: |
| 6 |
> |
| 7 |
> I just noticed that portage has atomic_ofstream(). Would you prefer this |
| 8 |
> change to use atomic_ofstream() instead of using "with open()"? |
| 9 |
|
| 10 |
Yes, please do. Also, we can eliminate the earlier os.path.isdir by |
| 11 |
using os.makedirs(systemd_environment_dir, exist_ok=True). |
| 12 |
-- |
| 13 |
Thanks, |
| 14 |
Zac |
Archives