1 |
On Wed, Jan 25, 2017 at 10:42 PM, Zac Medico <zmedico@g.o> wrote: |
2 |
> On 01/25/2017 07:16 PM, Mike Gilbert wrote: |
3 |
>> Commit f143e58dd changed the return value of CleanLogs.clean() to a |
4 |
>> tuple (returncode, messages). |
5 |
>> |
6 |
>> X-Gentoo-Bug: 607236 |
7 |
>> X-Gentoo-Bug-URL: https://bugs.gentoo.org/607236 |
8 |
>> --- |
9 |
>> pym/_emerge/post_emerge.py | 6 +++--- |
10 |
>> 1 file changed, 3 insertions(+), 3 deletions(-) |
11 |
>> |
12 |
>> diff --git a/pym/_emerge/post_emerge.py b/pym/_emerge/post_emerge.py |
13 |
>> index 0cb533cf8..7e6063c52 100644 |
14 |
>> --- a/pym/_emerge/post_emerge.py |
15 |
>> +++ b/pym/_emerge/post_emerge.py |
16 |
>> @@ -29,10 +29,10 @@ def clean_logs(settings): |
17 |
>> return |
18 |
>> |
19 |
>> cleanlogs = CleanLogs() |
20 |
>> - errors = cleanlogs.clean(settings=settings) |
21 |
>> - if errors: |
22 |
>> + returncode, msgs = cleanlogs.clean(settings=settings) |
23 |
>> + if not returncode: |
24 |
>> out = portage.output.EOutput() |
25 |
>> - for msg in errors: |
26 |
>> + for msg in msgs: |
27 |
>> out.eerror(msg) |
28 |
>> |
29 |
>> def display_news_notification(root_config, myopts): |
30 |
>> |
31 |
> |
32 |
> I like Fixes: tags [1]. Otherwise, looks good. |
33 |
|
34 |
Thanks. I adjusted the commit message and pushed this. |