Gentoo Archives: gentoo-portage-dev

From: "Michał Górny" <mgorny@g.o>
To: gentoo-portage-dev@l.g.o
Cc: "Michał Górny" <mgorny@g.o>
Subject: [gentoo-portage-dev] [PATCH] [repoman] Allow empty LICENSE in acct-* packages
Date: Thu, 20 Jun 2019 12:33:07
Message-Id: 20190620123301.22207-1-mgorny@gentoo.org
1 Since acct-* packages do not create any files (except for keepfile
2 for the home directory), it is perfectly normal for the LICENSE
3 to be empty.
4 ---
5 repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py | 4 ++--
6 1 file changed, 2 insertions(+), 2 deletions(-)
7
8 diff --git a/repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py b/repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py
9 index 4c35bbc12..2edf8f7f2 100644
10 --- a/repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py
11 +++ b/repoman/lib/repoman/modules/scan/metadata/ebuild_metadata.py
12 @@ -39,8 +39,8 @@ class EbuildMetadata(ScanBase):
13 ebuild = kwargs.get('ebuild').get()
14 for pos, missing_var in enumerate(self.repo_settings.qadata.missingvars):
15 if not ebuild.metadata.get(missing_var):
16 - if kwargs.get('catdir') == "virtual" and \
17 - missing_var in ("HOMEPAGE", "LICENSE"):
18 + if (kwargs.get('catdir') in ("acct-group", "acct-user", "virtual")
19 + and missing_var in ("HOMEPAGE", "LICENSE")):
20 continue
21 if ebuild.live_ebuild and missing_var == "KEYWORDS":
22 continue
23 --
24 2.22.0

Replies