Archives
Archives
| From: | Brian Dolbec <dolsen@g.o> | ||
|---|---|---|---|
| To: | gentoo-portage-dev@l.g.o | ||
| Subject: | Re: [gentoo-portage-dev] [PATCH] egencache: Migrate _special_filename class to portage.utils.changelog for api use | ||
| Date: | Mon, 05 Dec 2016 05:34:02 | ||
| Message-Id: | 20161204213400.19116d1c.dolsen@gentoo.org | ||
| In Reply to: | Re: [gentoo-portage-dev] [PATCH] egencache: Migrate _special_filename class to portage.utils.changelog for api use by Zac Medico |
||
| 1 | On Sat, 3 Dec 2016 14:10:33 -0800 |
| 2 | Zac Medico <zmedico@g.o> wrote: |
| 3 | |
| 4 | > On 12/03/2016 01:49 PM, Brian Dolbec wrote: |
| 5 | > > + if self.file_type_lt(self, other): |
| 6 | > > + return True |
| 7 | > > + elif self.file_type_lt(other, self): |
| 8 | > > + return False |
| 9 | > |
| 10 | > Patch looks good, except there are 2 missed renames from file_type_lt |
| 11 | > to _file_type_lt above. |
| 12 | |
| 13 | |
| 14 | all issues fixed, and commit now pushed. |
| 15 | -- |
| 16 | Brian Dolbec <dolsen> |