Re: [gentoo-portage-dev] [PATCH] env-update: change prelink to use /etc/prelink.conf.d/portage.conf

[Zac Medico]

On Sat, May 11, 2013 at 12:45 PM, Mike Frysinger <vapier@g.o> wrote:
> +               # Migration code path.  If /etc/prelink.conf was generated by us, then
> +               # point it to the new stuff until the prelink package re-installs.
> +               prelink_conf = os.path.join(eroot, 'etc', 'prelink.conf')
> +               if os.path.exists(prelink_conf):
> +                       if open(prelink_conf).readline() == '# prelink.conf autogenerated by env-update; make all changes to\n':

I would do it like this:

    with open(prelink_conf, 'rb') as f:
       if f.readline() == b'# prelink.conf autogenerated by
env-update; make all changes to\n':

The "with" block prevents resource warning messages with python3, and
using binary mode side-steps potential unicode decode errors.

Other than that, the patch looks good to me.