Re: [gentoo-portage-dev] [PATCH v2] __dyn_install: improve reporting of build and image sizes

[Fabian Groffen]

On 27-08-2017 12:53:23 -0700, Zac Medico wrote:
> On 08/27/2017 08:06 AM, Fabian Groffen wrote:
> > Prior to this commit, the reported sizes would look like:
> >
> >  * Final size of build directory: 34942 KiB
> >  * Final size of installed tree: 5627 KiB
> >
> > Because the sizes aren't aligned, it is hard to (visually) compare them.
> > On top of this, because the numbers are sometimes bigger, print a human
> > friendly size after the KiB size if applicable, like so:
> >
> >  * Final size of build directory: 1906 KiB (1.8 MiB)
> >  * Final size of installed tree:     7 KiB
> >
> > It should be noted that in case both sizes have a human-readable
> > variant, they are also aligned.
> >
> > The helper functions are defined and used in a subshell to avoid
> > pollution of the caller's environment.
> > ---
> >  bin/phase-functions.sh | 53 ++++++++++++++++++++++++++++++++++++++++++++++----
> >  1 file changed, 49 insertions(+), 4 deletions(-)
>
> Looks good. Please merge.

Pushed, thanks!

Fabian

-- 
Fabian Groffen
Gentoo on a different level