Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o
Cc: Zac Medico <zmedico@g.o>
Subject: [gentoo-portage-dev] [PATCH 3/3] glsa-check: Remove 'new' target from glsa-list
Date: Fri, 30 Aug 2019 23:03:42
Message-Id: 20190830230314.7597-4-zmedico@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH 0/3] glsa-check: forward port remaining changes from gentoolkit (bug 693088) by Zac Medico
1 This patch is a forward port of the following commit:
2
3 https://gitweb.gentoo.org/proj/gentoolkit.git/commit/?id=8190a7299a618e0ce120fe1c894b944075576342
4
5 commit 8190a7299a618e0ce120fe1c894b944075576342
6 Author: rbu <rbu@g.o>
7 AuthorDate: 2009-08-18 18:25:59 +0000
8 Commit: rbu <rbu@g.o>
9 CommitDate: 2009-08-18 18:25:59 +0000
10
11 Remove 'new' target from glsa-list
12
13 Everyone should use 'affected' or 'all'
14 Update man page and changelog
15
16 svn path=/trunk/gentoolkit/; revision=672
17
18 Bug: https://bugs.gentoo.org/693088
19 Signed-off-by: Zac Medico <zmedico@g.o>
20 ---
21 bin/glsa-check | 11 ++++++-----
22 1 file changed, 6 insertions(+), 5 deletions(-)
23
24 diff --git a/bin/glsa-check b/bin/glsa-check
25 index bf81eca63..7a6916d15 100755
26 --- a/bin/glsa-check
27 +++ b/bin/glsa-check
28 @@ -26,7 +26,7 @@ __version__ = "1.0.1"
29 # option parsing
30 epilog = "glsa-list can contain an arbitrary number of GLSA ids," \
31 " filenames containing GLSAs or the special identifiers" \
32 - " 'all', 'new' and 'affected'"
33 + " 'all' and 'affected'"
34 parser = argparse.ArgumentParser(usage=__program__ + " <option> [glsa-id | all | new | affected]",
35 epilog=epilog)
36
37 @@ -64,7 +64,7 @@ parser.add_argument("-v", "--verbose", action="store_true", dest="verbose",
38 parser.add_argument("-n", "--nocolor", action="store_true",
39 help="Removes color from output")
40 parser.add_argument("-e", "--emergelike", action="store_false", dest="least_change",
41 - help="Do not use a least-change algorithm")
42 + help="Upgrade to latest version (not least-change)")
43 parser.add_argument("-c", "--cve", action="store_true", dest="list_cve",
44 help="Show CVE IDs in listing mode")
45
46 @@ -101,7 +101,7 @@ elif mode in ["fix", "inject"] and os.geteuid() != 0:
47 sys.stderr.write("\nThis tool needs root access to "+options.mode+" this GLSA\n\n")
48 sys.exit(2)
49 elif mode == "list" and not params:
50 - params.append("new")
51 + params.append("affected")
52
53 # delay this for speed increase
54 from portage.glsa import (Glsa, GlsaTypeException, GlsaFormatException,
55 @@ -119,14 +119,15 @@ todolist = [e for e in completelist if e not in checklist]
56
57 glsalist = []
58 if "new" in params:
59 - glsalist = todolist
60 params.remove("new")
61 + sys.stderr.write("Warning: The 'new' glsa-list target has been removed, using 'affected'.\n")
62 + params.append("affected")
63
64 if "all" in params:
65 glsalist = completelist
66 params.remove("all")
67 +
68 if "affected" in params:
69 - # replaced completelist with todolist on request of wschlich
70 for x in todolist:
71 try:
72 myglsa = Glsa(x, portage.settings, vardb, portdb)
73 --
74 2.21.0