Re: [gentoo-portage-dev] [PATCH] match_from_list: restrict =* to match only on version part boundaries (bug 560466)

[Brian Dolbec]

On Mon, 21 Sep 2015 09:09:04 -0700
Zac Medico <zmedico@g.o> wrote:

> On 09/20/2015 10:39 PM, Ulrich Mueller wrote:
> >>>>>> On Sun, 20 Sep 2015, Zac Medico wrote:
> >
> >> Make the =* glob match only on boundaries between version parts, in
> >> order to eliminate ambiguity (so that 1* does not match version
> >> 10). Only break compatibility in cases where dependencies have been
> >> specified ambiguously.
> >
> > Does this patch consider suffix parts (including the integer if
> > present) as a single component?
>
> No, it considers the integer parts as a separate components, in order
> to maintain as much backward compatibility as possible.
>
> So, it deviates from your test cases only because =cat/foo-1_alpha*
> matches cat/foo-1_alpha1. Note that this case is not ambiguous like
> the others, so we may not want to break compatibility here.
>
> >
> > That is, the following should match:
> >
> >    =cat/foo-1_alpha* cat/foo-1_alpha_beta
> >
> > But these should *not*:
> >
> >    =cat/foo-1_p* cat/foo-1_pre
> >    =cat/foo-1_alpha* cat/foo-1_alpha1
> >
> > (The boundary of the version components is after _alpha and _alpha1,
> > respectively.)
> >
> > Ulrich
> >
>
>

Ok, merged approved, we can tighten it up more later easier than going
too tight now and causing some tree havoc.


-- 
Brian Dolbec <dolsen>