Gentoo Archives: gentoo-portage-dev

From: Zac Medico <zmedico@g.o>
To: gentoo-portage-dev@l.g.o, Matt Turner <mattst88@g.o>
Subject: Re: [gentoo-portage-dev] [PATCH gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps
Date: Mon, 02 Mar 2020 06:39:32
Message-Id: 35e8635f-2ed1-91e7-2eb8-04ffc04040c3@gentoo.org
In Reply to: [gentoo-portage-dev] [PATCH gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps by Matt Turner
1 On 2/20/20 9:29 PM, Matt Turner wrote:
2 > @@ -564,7 +577,22 @@ def findPackages(
3 >
4 > # Exclude if binpkg exists in the porttree and not --deep
5 > if not destructive and port_dbapi.cpv_exists(cpv):
6 > - continue
7 > + if not options['changed-deps']:
8 > + continue
9 > +
10 > + uselist = bin_dbapi.aux_get(cpv, ['USE'])[0].split()
11 > + all_equal = True
12 > +
13 > + for k in ('RDEPEND', 'PDEPEND'):
14 > + binpkg_deps = bin_dbapi.aux_get(cpv, [k])
15 > + ebuild_deps = port_dbapi.aux_get(cpv, [k])
16 > +
17 > + if not _deps_equal(binpkg_deps, ebuild_deps, cpv.eapi, uselist):
18 > + all_equal = False
19 > + break
20 > +
21 > + if all_equal:
22 > + continue
23
24 If all_equal is True, then none of the other filters have an opportunity
25 to add this package to the dead_binpkgs set. That's not good is it?
26 --
27 Thanks,
28 Zac

Attachments

File name MIME type
signature.asc application/pgp-signature

Replies